syncope-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From IsurangaPerera <...@git.apache.org>
Subject [GitHub] syncope pull request #70: [SYNCOPE-1301] fixed
Date Thu, 12 Apr 2018 13:53:56 GMT
Github user IsurangaPerera commented on a diff in the pull request:

    https://github.com/apache/syncope/pull/70#discussion_r181089295
  
    --- Diff: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPAAccessToken.java
---
    @@ -44,7 +44,7 @@
         @Temporal(TemporalType.TIMESTAMP)
         private Date expiryTime;
     
    -    @Column(nullable = true)
    +    @Column(unique = true)
    --- End diff --
    
    I think in JPA it is redundant to use nullable = true this is the default scenario or
all columns in JPA. Should I still change it?


---

Mime
View raw message