syncope-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilgrosso <...@git.apache.org>
Subject [GitHub] syncope issue #65: Correcting errors in the documentation
Date Fri, 16 Feb 2018 08:04:33 GMT
Github user ilgrosso commented on the issue:

    https://github.com/apache/syncope/pull/65
  
    Thanks @rohanjulka19 I have just merged your contribution.
    Please consider sending an [ICLA](http://syncope.apache.org/contributing.html#How_do_I_become_a_contributor_or_a_committer)
    
    Few notes:
    1. I had to rebase and squash your commits into one, please do this for your future contributions
    1. You probably did not attempt to build the docs, as there was a typo on the first license
line of `src/main/asciidoc/reference-guide/workingwithapachesyncope/cli/user.adoc` which was
breaking the build - to build docs, follow instructions at http://syncope.apache.org/building.html#Building_documentation
    1. Not sure why you have replaced 'behavior' with 'behaviour' everywhere, but I accepted
the change anyway :-)


---

Mime
View raw message