Mailing-List: contact dev-help@syncope.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@syncope.apache.org
Date: Thu, 7 Dec 2017 10:54:00 +0000 (UTC)
From: =?utf-8?Q?Francesco_Chicchiricc=C3=B2_=28JIRA=29?= <jira@apache.org>
To: dev@syncope.apache.org
Message-ID: <JIRA.13122230.1512151480000.407159.1512644040147@Atlassian.JIRA>
In-Reply-To: <JIRA.13122230.1512151480000@Atlassian.JIRA>
References: <JIRA.13122230.1512151480000@Atlassian.JIRA> <JIRA.13122230.1512151480534@jira-lw-us.apache.org>
Subject: [jira] [Commented] (SYNCOPE-1243) Add information to GroupTO about
 user and AnyObject membership counts
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 07 Dec 2017 10:54:05 -0000


    [ https://issues.apache.org/jira/browse/SYNCOPE-1243?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16=
281682#comment-16281682 ]=20

Francesco Chicchiricc=C3=B2 commented on SYNCOPE-1243:
-------------------------------------------------

Also, I would leverage some {{COUNT}} for replacing this:

{code}
+        for (AMembership membership : groupDAO.findAMemberships(group)) {
+            String key =3D membership.getLeftEnd().getType().getKey();
+            if (groupTO.getStaticAnyObjectMembershipCount().containsKey(ke=
y)) {
+                int oldCount =3D groupTO.getStaticAnyObjectMembershipCount=
().get(key);
+                groupTO.getStaticAnyObjectMembershipCount().put(key, ++old=
Count);
+            } else {
+                groupTO.getStaticAnyObjectMembershipCount().put(key, 1);
+            }
+        }
{code}

in order to avoid cycling on a (possibly huge) number of memberships.

> Add information to GroupTO about user and AnyObject membership counts
> ---------------------------------------------------------------------
>
>                 Key: SYNCOPE-1243
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-1243
>             Project: Syncope
>          Issue Type: Improvement
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>            Priority: Minor
>             Fix For: 2.0.7, 2.1.0
>
>         Attachments: SYNCOPE-1243.patch, SYNCOPE-1243.patch.2
>
>
> If we want to find out how many users or AnyObjects are members of a give=
n group, it's not possible to figure out via the group itself. Instead we n=
eed to run a fiql on the users or Any Objects.
> This task is to add the following fields to GroupTO so that we can get th=
is information more easily:
>   - int staticUserMembershipCount
>   - int dynamicUserMembershipCount
>   - Map<String, Integer> staticAnyObjectMembershipCount
>   - Map<String, Integer> dynamicAnyObjectMembershipCount


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)