Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B2D6F200D4F for ; Wed, 6 Dec 2017 16:54:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B1820160C1D; Wed, 6 Dec 2017 15:54:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 03348160BFD for ; Wed, 6 Dec 2017 16:54:04 +0100 (CET) Received: (qmail 23104 invoked by uid 500); 6 Dec 2017 15:54:04 -0000 Mailing-List: contact dev-help@syncope.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@syncope.apache.org Delivered-To: mailing list dev@syncope.apache.org Received: (qmail 23093 invoked by uid 99); 6 Dec 2017 15:54:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Dec 2017 15:54:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7D756C734D for ; Wed, 6 Dec 2017 15:54:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id eI2O-78-0jsY for ; Wed, 6 Dec 2017 15:54:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 76EA35F397 for ; Wed, 6 Dec 2017 15:54:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C6467E2583 for ; Wed, 6 Dec 2017 15:54:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B0394255CE for ; Wed, 6 Dec 2017 15:54:00 +0000 (UTC) Date: Wed, 6 Dec 2017 15:54:00 +0000 (UTC) From: "Colm O hEigeartaigh (JIRA)" To: dev@syncope.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SYNCOPE-1243) Add information to GroupTO about user and AnyObject membership counts MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 06 Dec 2017 15:54:05 -0000 [ https://issues.apache.org/jira/browse/SYNCOPE-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280353#comment-16280353 ] Colm O hEigeartaigh commented on SYNCOPE-1243: ---------------------------------------------- Thanks for the review Francesco. Some comments: a) int countUDynMembers(Group group); Is this really necessary? The implementation is just "return findUDynMembers(group).size();". b) int countADynMembers(Group group); I'll have to change this to "public int countADynMembers(final Group group, final String key)" or else "public Map countADynMembers(final Group group)" - WDYT? > Add information to GroupTO about user and AnyObject membership counts > --------------------------------------------------------------------- > > Key: SYNCOPE-1243 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1243 > Project: Syncope > Issue Type: Improvement > Reporter: Colm O hEigeartaigh > Assignee: Colm O hEigeartaigh > Priority: Minor > Fix For: 2.0.7, 2.1.0 > > Attachments: SYNCOPE-1243.patch > > > If we want to find out how many users or AnyObjects are members of a given group, it's not possible to figure out via the group itself. Instead we need to run a fiql on the users or Any Objects. > This task is to add the following fields to GroupTO so that we can get this information more easily: > - int staticUserMembershipCount > - int dynamicUserMembershipCount > - Map staticAnyObjectMembershipCount > - Map dynamicAnyObjectMembershipCount -- This message was sent by Atlassian JIRA (v6.4.14#64029)