Mailing-List: contact dev-help@syncope.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@syncope.apache.org
Date: Wed, 12 Jul 2017 11:57:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@syncope.apache.org
Message-ID: <JIRA.13084517.1499168618000.227550.1499860620170@Atlassian.JIRA>
In-Reply-To: <JIRA.13084517.1499168618000@Atlassian.JIRA>
References: <JIRA.13084517.1499168618000@Atlassian.JIRA> <JIRA.13084517.1499168618753@jira-lw-us.apache.org>
Subject: [jira] [Commented] (SYNCOPE-1144) Customizable Audit appender
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 12 Jul 2017 11:57:04 -0000


    [ https://issues.apache.org/jira/browse/SYNCOPE-1144?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16=
083867#comment-16083867 ]=20

ASF GitHub Bot commented on SYNCOPE-1144:
-----------------------------------------

Github user ilgrosso commented on a diff in the pull request:

    https://github.com/apache/syncope/pull/52#discussion_r126933815
 =20
    --- Diff: core/logic/src/main/java/org/apache/syncope/core/logic/Logger=
Logic.java ---
    @@ -216,10 +228,71 @@ private LoggerTO setLevel(final String name, fina=
l Level level, final LoggerType
             syncopeLogger.setLevel(LoggerLevel.fromLevel(level));
             syncopeLogger =3D loggerDAO.save(syncopeLogger);
    =20
    +        boolean isAudit =3D LoggerType.AUDIT.equals(syncopeLogger.getT=
ype());
             LoggerContext ctx =3D (LoggerContext) LogManager.getContext(fa=
lse);
    +        String domainAuditLoggerName =3D
    +                AuditManagerImpl.getDomainAuditEventLoggerName(AuthCon=
textUtils.getDomain(), syncopeLogger.
    +                        getKey());
             LoggerConfig logConf =3D SyncopeConstants.ROOT_LOGGER.equals(n=
ame)
                     ? ctx.getConfiguration().getLoggerConfig(LogManager.RO=
OT_LOGGER_NAME)
    -                : ctx.getConfiguration().getLoggerConfig(name);
    +                : isAudit
    +                        ? ctx.getConfiguration().getLoggerConfig(domai=
nAuditLoggerName)
    +                        : ctx.getConfiguration().getLoggerConfig(name)=
;
    +
    +        if (isAudit) {
    +            // SYNCOPE-1144 For each custom audit appender class add r=
elated appenders to log4j logger
    --- End diff --
   =20
    Isn't this code a copy of what inserted in `LoggerLoader`? If so, pleas=
e extract it into a public method in `LoggerLoader` and invoke that from he=
re too.


> Customizable Audit appender
> ---------------------------
>
>                 Key: SYNCOPE-1144
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-1144
>             Project: Syncope
>          Issue Type: New Feature
>          Components: common, console, core
>            Reporter: Francesco Chicchiricc=C3=B2
>            Assignee: Andrea Patricelli
>             Fix For: 2.0.5, 2.1.0
>
>
> The Audit mechanism is based on LOG4J, configured to use the {{JDBCAppend=
er}} to store the audit statements into the {{SyncopeAudit}} table in the i=
nternal storage.
> Besides this base mechanism, we can introduce the {{AuditAppender}} inter=
face, whose instances can:
> # declare which event(s) they will be invoked with
> # declare another LOG4J appender to send the statements to (besides the {=
{JDBCAppender}} as above)
> # optionally offer the ability to transform the standard statement to a f=
ormat more suitable to the target appender


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)