Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5EA3F200CC2 for ; Wed, 5 Jul 2017 10:19:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5D876162A5B; Wed, 5 Jul 2017 08:19:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A38A0162A5A for ; Wed, 5 Jul 2017 10:19:53 +0200 (CEST) Received: (qmail 8033 invoked by uid 500); 5 Jul 2017 08:19:52 -0000 Mailing-List: contact dev-help@syncope.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@syncope.apache.org Delivered-To: mailing list dev@syncope.apache.org Received: (qmail 8022 invoked by uid 99); 5 Jul 2017 08:19:52 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jul 2017 08:19:52 +0000 Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com [209.85.192.182]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 411F01A0029 for ; Wed, 5 Jul 2017 08:19:51 +0000 (UTC) Received: by mail-pf0-f182.google.com with SMTP id q85so12601304pfq.1 for ; Wed, 05 Jul 2017 01:19:50 -0700 (PDT) X-Gm-Message-State: AIVw111w8PE3Y/aZoV743u+64FV0Ny+ejy+QznsC/u67vMrGEfNuGPN4 Pk6Ov6IsPfu/7LJotrw6K3fgkv9GPA== X-Received: by 10.84.194.37 with SMTP id g34mr14374560pld.111.1499242789799; Wed, 05 Jul 2017 01:19:49 -0700 (PDT) MIME-Version: 1.0 Reply-To: coheigea@apache.org Received: by 10.100.164.69 with HTTP; Wed, 5 Jul 2017 01:19:49 -0700 (PDT) In-Reply-To: <7a434a16-98e6-3737-b3a7-686311faa92c@apache.org> References: <7a434a16-98e6-3737-b3a7-686311faa92c@apache.org> From: Colm O hEigeartaigh Date: Wed, 5 Jul 2017 09:19:49 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Third-party JWT integration To: "dev@syncope.apache.org" Content-Type: multipart/alternative; boundary="94eb2c188492eb10d605538da987" archived-at: Wed, 05 Jul 2017 08:19:54 -0000 --94eb2c188492eb10d605538da987 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Just committed! Colm. On Wed, Jul 5, 2017 at 9:15 AM, Francesco Chicchiricc=C3=B2 wrote: > On 05/07/2017 10:12, Colm O hEigeartaigh wrote: > >> OK will do! I'll check in an @Ignore'd test that I wrote, feel free to >> modify or replace it if you want. >> > > Sure. Where is the test code located? I cannot find it.. > > Regards. > > On Tue, Jul 4, 2017 at 7:05 PM, Francesco Chicchiricc=C3=B2 < >> ilgrosso@apache.org> >> wrote: >> >> Hi Colm, >>> you're definitely right: please go ahead and open an issue, I'll fix th= at >>> right away (and also add a good test for this feature). >>> >>> Regards. >>> >>> Il 4 luglio 2017 17:12:34 CEST, Colm O hEigeartaigh >> > >>> ha scritto: >>> >>> I'm testing the recent functionality that was added to enable >>>> third-party >>>> JWT integration with Syncope. Unless I'm missing something, it's not >>>> working at the moment, as the following method needs to be updated to >>>> allow >>>> the case where no access token is present? >>>> >>>> https://github.com/apache/syncope/blob/master/core/spring/ >>>> src/main/java/org/apache/syncope/core/spring/security/ >>>> AuthDataAccessor.java#L389 >>>> >>>> Even if I have a custom JWTSSOProvider plugged in, there is still an >>>> error >>>> about not finding a corresponding access token. >>>> >>>> Colm. >>>> >>> > -- > Francesco Chicchiricc=C3=B2 > > Tirasa - Open Source Excellence > http://www.tirasa.net/ > > Member at The Apache Software Foundation > Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail > http://home.apache.org/~ilgrosso/ > > --=20 Colm O hEigeartaigh Talend Community Coder http://coders.talend.com --94eb2c188492eb10d605538da987--