syncope-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilgrosso <...@git.apache.org>
Subject [GitHub] syncope pull request #50: Connector and Resource configuration versioning in...
Date Wed, 12 Jul 2017 06:58:57 GMT
Github user ilgrosso commented on a diff in the pull request:

    https://github.com/apache/syncope/pull/50#discussion_r126877126
  
    --- Diff: client/console/src/main/java/org/apache/syncope/client/console/wicket/markup/html/form/JsonDiffEditorPanel.java
---
    @@ -0,0 +1,69 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.syncope.client.console.wicket.markup.html.form;
    +
    +import org.apache.syncope.client.console.panels.AbstractModalPanel;
    +import org.apache.syncope.client.console.wicket.markup.html.bootstrap.dialog.BaseModal;
    +import org.apache.wicket.PageReference;
    +import org.apache.wicket.markup.head.IHeaderResponse;
    +import org.apache.wicket.markup.head.OnLoadHeaderItem;
    +import org.apache.wicket.markup.html.form.TextArea;
    +import org.apache.wicket.model.IModel;
    +
    +public class JsonDiffEditorPanel extends AbstractModalPanel<String> {
    --- End diff --
    
    I'd rather name this class `JsonDIffPanel` since you are not actually allowing any edit
through it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message