Mailing-List: contact dev-help@syncope.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@syncope.apache.org
Subject: Re: JPAConfDao ClassCastException
To: dev@syncope.apache.org
References: <CAB8XdGC09ef59ePVQM8D2SNcjrV_CJkycL4xsUT1ftCs1TO6pg@mail.gmail.com>
From: =?UTF-8?Q?Francesco_Chicchiricc=c3=b2?= <ilgrosso@apache.org>
Message-ID: <b4990e04-673d-d03c-1b69-42cce71aa672@apache.org>
Date: Tue, 13 Dec 2016 13:40:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <CAB8XdGC09ef59ePVQM8D2SNcjrV_CJkycL4xsUT1ftCs1TO6pg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
archived-at: Tue, 13 Dec 2016 12:40:13 -0000

On 13/12/2016 13:31, Colm O hEigeartaigh wrote:
> The following case in JPAConfDao will result in a ClassCastException as
> JPACPlainAttrValue does not implement the interface PlainAttrUniqueValue.
>
> JPACPlainAttrValue attrValue;
> if (newAttr.getSchema().isUniqueConstraint()) {
>      attrValue = new JPACPlainAttrValue();
>      ((PlainAttrUniqueValue) attrValue).setSchema(newAttr.getSchema());
> }
>
> What should this be instead?


I guess you are referring to [1]; to me, the highlighted snippet should 
become

                 PlainAttrValue attrValue;
                 if (newAttr.getSchema().isUniqueConstraint()) {
                     attrValue = new JPACPlainAttrUniqueValue();
                     ((PlainAttrUniqueValue) 
attrValue).setSchema(newAttr.getSchema());
                 } else {
                     attrValue = new JPACPlainAttrValue();
                 }

WDYT?

[1] 
https://github.com/apache/syncope/blob/2_0_X/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAConfDAO.java#L71-L77

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/