syncope-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilgrosso <...@git.apache.org>
Subject [GitHub] syncope issue #40: SYNCOPE-971: Case insensitive search
Date Wed, 23 Nov 2016 14:49:10 GMT
Github user ilgrosso commented on the issue:

    https://github.com/apache/syncope/pull/40
  
    @gonzalad thanks for your work, the changes now look very good!
    
    I have some troubles when merging your PR directly (as you've forked from the master branch,
I think) + there are some minor issues to clean up (unused `ConfDAO`, for example).
    
    Moreover, the CXF dependency must be upgraded to 3.1.9-SNAPSHOT in oder to get the changes
pushed yesterday.
    The error from `MigrationITCase` is randomly occurring, and it is probably related to
some timing issue, so do not care about it.
    
    Finally, once merged this PR, I will apply it to the `master` branch too (with no modifications)
+ I will port it to the `1_2_X` branch (which will instead require some intervention.
    
    Thanks again!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message