syncope-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilgrosso <...@git.apache.org>
Subject [GitHub] syncope pull request #40: SYNCOPE-971: Case insensitive search
Date Tue, 22 Nov 2016 07:58:09 GMT
Github user ilgrosso commented on a diff in the pull request:

    https://github.com/apache/syncope/pull/40#discussion_r89058906
  
    --- Diff: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAnySearchDAO.java
---
    @@ -769,7 +783,12 @@ private void fillAttributeQuery(final StringBuilder query, final
PlainAttrValue
                         if (not) {
                             query.append(" NOT ");
                         }
    -                    query.append(" LIKE ?").append(setParameter(parameters, cond.getExpression()));
    +                    query.append(" LIKE ");
    --- End diff --
    
    Ah, it seems you're right, good to know!
    
    For additional safety, I have found references for [H2](http://www.h2database.com/html/functions.html#lower),
[MySQL](http://www.sqlinfo.net/mysql/mysql_function_upper_lower.php), [PostgreSQL](https://www.postgresql.org/docs/9.3/static/functions-string.html),
[Oracle DB](http://www.sqlinfo.net/oracle/oracle_function_upper_lower.php), [MS SQL Server](http://www.sqlinfo.net/sqlserver/sql_server_function_upper_lower.php),
hence all of our supported DBMSes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message