syncope-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nuwan Sameera <nuwansameer...@gmail.com>
Subject Re: Fwd: [Syncope-808] How I send PR to upstream
Date Tue, 12 Jul 2016 11:55:02 GMT
Hi,

I read [1] and [2] for get solution for above WARNINGS. But they says these
are solved. I cannot found something to do.

[1] https://netbeans.org/bugzilla/show_bug.cgi?id=248015
[2] https://netbeans.org/bugzilla/show_bug.cgi?id=210286

Regards,
Nuwan Sameera.

On Mon, Jul 11, 2016 at 2:41 PM, Nuwan Sameera <nuwansameera74@gmail.com>
wrote:

> Hi,
>
> (01) Rename property from <netbenas.version>RELEASE81</netbenas.version>
> to
> <netbeans.version>RELEASE81</netbeans.version>
>
> I tried to remove other warnings. I sent mail to @dev in netbeans to
> solution. I will do it ASSP.
> I run project without problem. In this time these Warnings are not problem.
>
> Regards,
> Nuwan Sameera.
>
>
> On Mon, Jul 11, 2016 at 12:52 PM, andrea <andrea.patricelli@tirasa.net>
> wrote:
>
>>
>>
>> Il 09/07/2016 04:41, Nuwan Sameera ha scritto:
>>
>>> Hi all,
>>>
>>
>> Hi Nuwan,
>>
>> please see inline.
>>
>>>
>>> I formatted all source files and license headers. Now netbeans plugin
>>> build
>>> with checkstyle check and rat check. All the source codes are available
>>> in
>>> [1]
>>>
>>>      [1]
>>> https://github.com/NuwanSameera/syncope/tree/master/netbeans-plugin
>>>
>>> Please check and now is my code OK to PR?
>>>
>>
>> Good job, but there are some other steps to PR.
>>
>> There is a typo in parent pom.xml:
>> <netbenas.version>RELEASE81</netbenas.version> instead of
>> <netbeans.version>RELEASE81</netbeans.version>, but is not so important.
>>
>> While building netbeans plugin project I see:
>>
>> [WARNING] bootstrap class path not set in conjunction with -source 1.7
>> [WARNING] Supported source version 'RELEASE_6' from annotation processor
>> 'org.netbeans.modules.openide.util.NbBundleProcessor' less than -source
>> '1.7'
>>
>> Could you investigate only to be sure that these are not problems?
>>
>> In the meanwhile I'll check functionalities of the plugin.
>>
>> Best regards,
>> Andrea
>>
>>
>>
>>> Thanks and Regards,
>>> Nuwan Sameera.
>>>
>>> On Thu, Jul 7, 2016 at 12:57 PM, andrea <andrea.patricelli@tirasa.net>
>>> wrote:
>>>
>>> Hi Nuwan,
>>>>
>>>> checkstyle check must be enabled and not skipped, and format of files
>>>> must
>>>> be the correct one, otherwise we cannot accept the PR.
>>>>
>>>> Best regards,
>>>> Andrea
>>>>
>>>>
>>>> Il 06/07/2016 19:29, Nuwan Sameera ha scritto:
>>>>
>>>> Hi,
>>>>>
>>>>> I tried to formatted files in apache code format. There are many auto
>>>>> generated files contain in plugin. I am problem with format then. So
>>>>> up to
>>>>> now check-style skipped.
>>>>>
>>>>>    Regards,
>>>>> Nuwan Sameera.
>>>>>
>>>>> On Wed, Jul 6, 2016 at 7:55 PM, Nuwan Sameera <
>>>>> nuwansameera74@gmail.com>
>>>>> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>>> Sorry for the mistake.
>>>>>>
>>>>>> Regards.
>>>>>>
>>>>>> On Wed, Jul 6, 2016 at 7:33 PM, andrea <andrea.patricelli@tirasa.net>
>>>>>> wrote:
>>>>>>
>>>>>> Hi Nuwan,
>>>>>>
>>>>>>> no need to forward the same message to us. We already see the
mails
>>>>>>> in
>>>>>>> mailing list dev@syncope.apache.org
>>>>>>>
>>>>>>> We will answer to you as soon as we can.
>>>>>>>
>>>>>>> Best regards,
>>>>>>> Andrea
>>>>>>>
>>>>>>>
>>>>>>> Il 06/07/2016 15:51, Nuwan Sameera ha scritto:
>>>>>>>
>>>>>>>
>>>>>>> ---------- Forwarded message ----------
>>>>>>> From: Nuwan Sameera <nuwansameera74@gmail.com>
>>>>>>> Date: Wed, Jul 6, 2016 at 6:30 PM
>>>>>>> Subject: Re: [Syncope-808] How I send PR to upstream
>>>>>>> To: dev@syncope.apache.org
>>>>>>>
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I resolved problem you asked in github pull request. I replied
to
>>>>>>> your
>>>>>>> comments. Source code available in [1]
>>>>>>>          [1] https://github.com/NuwanSameera/syncope
>>>>>>>
>>>>>>> TODO : Need to add checkstyle and license header check.
>>>>>>>        I will do this ASSP.
>>>>>>>
>>>>>>> Please check my changes and give me feedback.
>>>>>>>
>>>>>>> Regards,
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Jul 6, 2016 at 1:17 PM, andrea <andrea.patricelli@tirasa.net
>>>>>>> >
>>>>>>> wrote:
>>>>>>>
>>>>>>> Hi Nuwan,
>>>>>>>
>>>>>>>> I commented almost all files of your PR and left you a feedback
>>>>>>>> about
>>>>>>>> the PR.
>>>>>>>>
>>>>>>>> You have, at least, to close the open points described in
the
>>>>>>>> previous
>>>>>>>> email (especially code formatting, correct license headers
and
>>>>>>>> functionalities)  and then we could take into account to
accept pull
>>>>>>>> request.
>>>>>>>>
>>>>>>>> See other comments inline.
>>>>>>>>
>>>>>>>> Il 06/07/2016 08:02, Nuwan Sameera ha scritto:
>>>>>>>>
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>>> "Suggestion: you can also open an issue for each point
on your Git
>>>>>>>>> repository NuwanSameera/syncope. It will be very useful
for you and
>>>>>>>>> for us
>>>>>>>>> to check developments."
>>>>>>>>>
>>>>>>>>> I don't enable create new issue option in NuwanSameera/syncope.
>>>>>>>>> There
>>>>>>>>> is no option describe in [1]
>>>>>>>>>           [1] https://help.github.com/articles/creating-an-issue/
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> I think that you are able to open issues on our private
repo, maybe
>>>>>>>>>
>>>>>>>> you
>>>>>>>> have only to enable issues on you private repo.
>>>>>>>>
>>>>>>>> I do following changes in netbeans plugin. All the source
codes are
>>>>>>>>
>>>>>>>> available in [2]
>>>>>>>>>          [2]
>>>>>>>>> https://github.com/NuwanSameera/syncope/tree/master/netbeans-plugin
>>>>>>>>>
>>>>>>>>> Changes:
>>>>>>>>>
>>>>>>>>> "1. add dependencies in the root (father) pom.xml, versions
of
>>>>>>>>> dependencies must be maven properties so that you can
change them
>>>>>>>>> easily.
>>>>>>>>>       Then you can import dependencies in the child project
(your
>>>>>>>>> project) without specifying versions.
>>>>>>>>>
>>>>>>>>> 2. Additional netbeans repository definition must be
moved from
>>>>>>>>> child
>>>>>>>>> pom.xml to father (root) pms.xml into the tag "repositories".
"
>>>>>>>>> I Resolved above issues.
>>>>>>>>>
>>>>>>>>> "4. Remove org.apache.syncope.netbeans.pl <
>>>>>>>>> http://org.apache.syncope.netbeans.pl>ugin.entity.Test.java
>>>>>>>>> class! If
>>>>>>>>> you need to make some test (about plugin, if needed)
you must add
>>>>>>>>> test
>>>>>>>>> classes under src/test directory. But Test class is not
a test
>>>>>>>>> about
>>>>>>>>> plugin, so you can remove it."
>>>>>>>>> Remove Test.java class
>>>>>>>>>
>>>>>>>>> "5. Remove all @author javadoc."
>>>>>>>>> Remove @author anotation.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Other issues work in progress. I resolve them soon. Please
check
>>>>>>>>> and
>>>>>>>>> give me feedback.
>>>>>>>>>
>>>>>>>>> I send pull request to apache/syncope [3]
>>>>>>>>>            [3] https://github.com/apache/syncope/pull/27
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Ok I have commented PR. Follow instructions provided.
>>>>>>>>>
>>>>>>>>
>>>>>>>> Thanks Regards,
>>>>>>>>
>>>>>>>>> Nuwan Sameera.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Mon, Jul 4, 2016 at 4:14 PM, Nuwan Sameera <
>>>>>>>>> nuwansameera74@gmail.com
>>>>>>>>> <mailto:nuwansameera74@gmail.com>> wrote:
>>>>>>>>>
>>>>>>>>>       Hi,
>>>>>>>>>
>>>>>>>>>       Thank you very much. I am work in progress.
>>>>>>>>>
>>>>>>>>>       Regards,
>>>>>>>>>       Nuwan Sameera
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>       On Mon, Jul 4, 2016 at 3:18 AM, andrea
>>>>>>>>>       <andrea.patricelli@tirasa.net
>>>>>>>>>       <mailto:andrea.patricelli@tirasa.net>>
wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>           Il 02/07/2016 11:29, Nuwan Sameera ha scritto:
>>>>>>>>>
>>>>>>>>>               Hi all,
>>>>>>>>>
>>>>>>>>>               I worked with [Syncope-808] as GSoC project.
Now I
>>>>>>>>> am not
>>>>>>>>>               in GSoC program.
>>>>>>>>>               But I would like to contribute [Syncope-808].
In this
>>>>>>>>> time
>>>>>>>>>               I did some
>>>>>>>>>               implementation about netbeans plugin.
>>>>>>>>>
>>>>>>>>>               All source codes are available in
>>>>>>>>>                             [1]
>>>>>>>>>
>>>>>>>>> https://github.com/NuwanSameera/syncope/tree/master/netbeans-plugin
>>>>>>>>>
>>>>>>>>>               All the instructions to how install and
run netbeans
>>>>>>>>>               plugin available in
>>>>>>>>>               * [GSoC 2016] [Syncope 808] *mail thread.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>           Hi Nuwan,
>>>>>>>>>
>>>>>>>>>           I had a look to your project, I checked code
and
>>>>>>>>> functionalities.
>>>>>>>>>           Here are some suggestions on how to proceed
to PR:
>>>>>>>>>
>>>>>>>>>           First of all you have to rebase your Apache
Syncope fork
>>>>>>>>> with
>>>>>>>>>           current Apache Syncope master. I.e. you have
to import
>>>>>>>>> all
>>>>>>>>>           commits done on apache:master to re-align your
project to
>>>>>>>>>           Apache Syncope one. Like GitHub says you are
78 commits
>>>>>>>>> behind
>>>>>>>>>           apache:master. You can use Git rebase command,
there is
>>>>>>>>> a lot
>>>>>>>>>           of documentation on the web.
>>>>>>>>>           There are some best paractises to follow while
developing
>>>>>>>>> with
>>>>>>>>>           Apache Syncope. Especially in the pom.xml you
have to:
>>>>>>>>>
>>>>>>>>>           1.  add dependencies in the root (father) pom.xml,
>>>>>>>>> versions
>>>>>>>>> of
>>>>>>>>>           dependencies must be maven properties so that
you can
>>>>>>>>> change
>>>>>>>>>           them easily.
>>>>>>>>>               Then you can import dependencies in the
child project
>>>>>>>>>           (your project) without specifying versions.
>>>>>>>>>
>>>>>>>>>           2. Additional netbeans repository definition
must be
>>>>>>>>> moved
>>>>>>>>>           from child pom.xml to father (root) pms.xml
into the tag
>>>>>>>>>           "repositories".
>>>>>>>>>
>>>>>>>>>           3. While building the project I see: *[WARNING]
The
>>>>>>>>> artifact
>>>>>>>>>           org.apache.commons:commons-io:jar:1.3.2 has
been
>>>>>>>>> relocated to
>>>>>>>>>           commons-io:commons-io:jar:1.3.2 Please check
if *this
>>>>>>>>> import
>>>>>>>>>           is really necessary and if you can solve this
warning. 4.
>>>>>>>>>           Remove
>>>>>>>>> org.apache.syncope.netbeans.plugin.entity.Test.java
>>>>>>>>>           class! If you need to make some test (about
plugin, if
>>>>>>>>> needed)
>>>>>>>>>           you must add test classes under src/test directory.
But
>>>>>>>>> Test
>>>>>>>>>           class is not a test about plugin, so you can
remove it.
>>>>>>>>>
>>>>>>>>>           5. Remove all @author javadoc.
>>>>>>>>>
>>>>>>>>>           6. Do you really need ianal-maven-plugin definition
and
>>>>>>>>>           configuration? I think that is enough father
pms.xml one.
>>>>>>>>>
>>>>>>>>>           7. remove*
>>>>>>>>>
>>>>>>>>>           <properties>
>>>>>>>>>
>>>>>>>>>            <checkstyle.skip>true</checkstyle.skip>
>>>>>>>>>
>>>>>>>>>                  <rat.skip>true</rat.skip>
>>>>>>>>>
>>>>>>>>>              </properties>*
>>>>>>>>>           These two properties must be removed, because
you project
>>>>>>>>> have
>>>>>>>>>           to build with checkstyle and rat checks enabled.
>>>>>>>>>
>>>>>>>>>           8. Plugin homepage <
>>>>>>>>> http://syncope.apache.org/netbeans-plugin/>
>>>>>>>>> http://syncope.apache.org/netbeans-plugin/
>>>>>>>>>           does not exist.
>>>>>>>>>
>>>>>>>>>           9. You must do a bit of refactoring putting
the project
>>>>>>>>> under
>>>>>>>>>           an higher level project IDE. I'll give you
details
>>>>>>>>> further.
>>>>>>>>>
>>>>>>>>>           10. I successfullty installed and tried to
use plugin,
>>>>>>>>> but
>>>>>>>>>           after I clicked on close button gave me an
error and I
>>>>>>>>> had to
>>>>>>>>>           restart netbeans to set new url, username and
password
>>>>>>>>> for
>>>>>>>>>           syncope endpoint. This is really disappointing.
>>>>>>>>>
>>>>>>>>>           11. Seems that sometimes Netbeans hangs and
nothing
>>>>>>>>> happens.
>>>>>>>>>           You could add a progress bar in the footer
of the browser
>>>>>>>>>           (like download or build) progress bar.
>>>>>>>>>           Can be this template loading non-blocking?
>>>>>>>>>
>>>>>>>>>           12. About report XSLTs: you do not have to
let the user
>>>>>>>>> choose
>>>>>>>>>           the format, because XSLT is the reference format.
You
>>>>>>>>> have to
>>>>>>>>>           show one XSLT file (tab or subtab like Source
and
>>>>>>>>> History)
>>>>>>>>> for
>>>>>>>>>           each format of the report (CSV, FO, HTML),
but format of
>>>>>>>>> the
>>>>>>>>>           file is always XSLT, could never exist sample
xslt that
>>>>>>>>> is
>>>>>>>>> .html.
>>>>>>>>>
>>>>>>>>>           13. After closing plugin and reconnecting I
see
>>>>>>>>> duplicated
>>>>>>>>>           templates in the left navigation toolbar of
the plugin,
>>>>>>>>> and a
>>>>>>>>>           duplicate is created every time I reconnect
why??
>>>>>>>>>
>>>>>>>>>           14. If I click on test mail template another
nothing
>>>>>>>>> happens.
>>>>>>>>>
>>>>>>>>>           15. How can I save remotely template? Just
clicking on
>>>>>>>>> Save
>>>>>>>>>           button? I tried but I did not see changes on
Syncope.
>>>>>>>>>
>>>>>>>>>           Suggestion: you can also open an issue for
each point on
>>>>>>>>> your
>>>>>>>>>           Git repository NuwanSameera/syncope. It will
be very
>>>>>>>>> useful
>>>>>>>>>           for you and for us to check developments.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>               I need feedback about my project and I
need to know
>>>>>>>>> how I
>>>>>>>>>               send PR to
>>>>>>>>>               upstream.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>           To send  a PR, after a rebase with Apache Syncope
>>>>>>>>> master, you
>>>>>>>>>           just click on New pull request button in your
project
>>>>>>>>> main
>>>>>>>>> page.
>>>>>>>>>
>>>>>>>>>               Thanks and Regards.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>           HTH best regards,
>>>>>>>>>           Andrea
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>       --     Nuwan Sameera.
>>>>>>>>>       Undergraduate,
>>>>>>>>>       Electronic and Telecommunication Engineering,
>>>>>>>>>       University of Moratuwa.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Nuwan Sameera.
>>>>>>>>> Undergraduate,
>>>>>>>>> Electronic and Telecommunication Engineering,
>>>>>>>>> University of Moratuwa.
>>>>>>>>>
>>>>>>>>> Best regards,
>>>>>>>>>
>>>>>>>> Andrea
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>> Nuwan Sameera.
>>>>>>> Undergraduate,
>>>>>>> Electronic and Telecommunication Engineering,
>>>>>>> University of Moratuwa.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Nuwan Sameera.
>>>>>>> Undergraduate,
>>>>>>> Electronic and Telecommunication Engineering,
>>>>>>> University of Moratuwa.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>> Nuwan Sameera.
>>>>>> Undergraduate,
>>>>>> Electronic and Telecommunication Engineering,
>>>>>> University of Moratuwa.
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>
>>
>
>
> --
> Nuwan Sameera.
> Undergraduate,
> Electronic and Telecommunication Engineering,
> University of Moratuwa.
>



-- 
Nuwan Sameera.
Undergraduate,
Electronic and Telecommunication Engineering,
University of Moratuwa.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message