syncope-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SYNCOPE-871) Link NumberWidgets on the dashboard to their respective pages
Date Thu, 16 Jun 2016 13:28:05 GMT

    [ https://issues.apache.org/jira/browse/SYNCOPE-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333764#comment-15333764
] 

ASF GitHub Bot commented on SYNCOPE-871:
----------------------------------------

Github user ilgrosso commented on a diff in the pull request:

    https://github.com/apache/syncope/pull/21#discussion_r67343220
  
    --- Diff: client/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java
---
    @@ -170,76 +175,101 @@ private WebMarkupContainer updateRealmContent(final RealmTO realmTO)
{
             if (realmTO == null) {
                 return content;
             }
    -        content.addOrReplace(new Realm("body", realmTO, getPageReference()) {
    +        content.addOrReplace(new RealmConcrete("body", realmTO, getPageReference()));
    +        return content;
    +    }
     
    -            private static final long serialVersionUID = 8221398624379357183L;
    +    private WebMarkupContainer updateRealmContent(final RealmTO realmTO, final int selectedIndex)
{
    +        if (realmTO == null) {
    +            return content;
    +        }
    +        content.addOrReplace(new RealmConcrete("body", realmTO, getPageReference(), selectedIndex));
    +        return content;
    +    }
     
    -            @Override
    -            protected void onClickTemplate(final AjaxRequestTarget target) {
    -                templates.setTargetObject(realmTO);
    -                templates.toggle(target, true);
    -            }
    +    class RealmConcrete extends Realm {
    --- End diff --
    
    I don't understand why you have created `RealmConcrete` instead of putting your additions
directly into `Realm`


> Link NumberWidgets on the dashboard to their respective pages
> -------------------------------------------------------------
>
>                 Key: SYNCOPE-871
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-871
>             Project: Syncope
>          Issue Type: Improvement
>          Components: console
>            Reporter: Tushar Mishra
>            Priority: Minor
>              Labels: user-experience
>             Fix For: 2.0.0
>
>
> To implement intuitive user experience, the NumberWidgets shown on the console's dashboard
should link to the following pages:
> Users -> Realms/User
> Groups -> Realms/Group
> Printers -> Realms/Printer
> Resources -> Topology



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message