syncope-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (SYNCOPE-866) Check for existence of key before adding template
Date Fri, 03 Jun 2016 12:51:59 GMT


ASF GitHub Bot commented on SYNCOPE-866:

Github user ilgrosso commented on the issue:
    LGTM, please squash your three commits into one, and don't forget to mention SYNCOPE-866
in the final commit log (the very first used here will work, anyway).
    I will merge this PR at earliest next Monday 6th, after that the freeze period due to
the ongoing release VOTE is over.

> Check for existence of key before adding template
> -------------------------------------------------
>                 Key: SYNCOPE-866
>                 URL:
>             Project: Syncope
>          Issue Type: Improvement
>          Components: core
>            Reporter: Tushar Mishra
>             Fix For: 2.0.0
> The create(String key) method in the MailTemplateLogic and ReportTemplateLogic classes
of the org.apache.syncope.core.logic package should check if the key being added to the MailTemplateDAO
instance is already present. If such a key already exists, it should throw an appropriate
exception for the same.

This message was sent by Atlassian JIRA

View raw message