syncope-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SYNCOPE-721) Enduser i18n
Date Thu, 16 Jun 2016 11:07:05 GMT

    [ https://issues.apache.org/jira/browse/SYNCOPE-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333570#comment-15333570
] 

ASF GitHub Bot commented on SYNCOPE-721:
----------------------------------------

Github user ilgrosso commented on a diff in the pull request:

    https://github.com/apache/syncope/pull/22#discussion_r67326414
  
    --- Diff: client/enduser/src/main/resources/META-INF/resources/app/views/self.html ---
    @@ -24,62 +24,39 @@
     
         <title>Apache Syncope Enduser - Login</title>
       </head>
    -
       <body>
    -
         <div ng-cloak class="container">
    -
    -      <div id="login-container" ng-controller="LoginController"  style="box-sizing:
border-box; ">
    -
    -        <!--        <div id="logo">
    -                  <a href="/">
    -                    <img class="login-logo" src="img/logo-green.png" />
    -                  </a>
    -                </div>-->
    +      <div id="login-container" ng-controller="LoginController"  ng-init="init" style="box-sizing:
border-box; ">
             <div id="login" class="card card-container">
               <div>
    -            <!--<div id="language" class="form-group" ng-controller="LanguageController"
ng-init="init()">
    -              <div id="languageContainer" class="col-xs-2">
    -
    -                <select class="form-control" ng-options="language.name for language
in languages.availableLanguages track by language.id"
    -                        ng-model="languages.selectedLanguage" ></select>
    -
    -              </div>
    -            </div>-->
    -
                 <img class="login-logo" src="img/logo-green.png" />
    -
                 <div id="login-form" class="form">              
                 </div>
    -
                 <form id="login-form" class="form form-signin" novalidate>
    -
                   <fieldset class="form-group input-group">
    -
                     <div class="form-group">
                       <input autofocus="autofocus" type="text" class="form-control" id="login-username"
placeholder="Username"
                              ng-required ng-model="credentials.username" placeholder="username">
                     </div>
    -
                     <div class="form-group">
                       <input type="password" class="form-control" id="login-password"
placeholder="Password" 
                              ng-required ng-model="credentials.password" placeholder="password">
                     </div>
    -
                     <div class="form-group">
    -
    +                  <select  ng-change="switchLanguage()" id="language" style="width:
100%" class="btn dropdown-toggle btn-default" 
    +                           ng-options="language.name for language in languages.availableLanguages
track by language.id" 
    +                           ng-model="languages.selectedLanguage"></select>
    +                </div>                
    +                <div class="form-group">
                       <button type="submit" id="login-btn" class="btn btn-default btn-signin
login-btn" 
                               ng-click="login(credentials)">Login</button>
                     </div>
                   </fieldset>
                 </form>
    -
               </div>
    -
             </div>
             <div class="text-center" ng-show="$root.isSelfRegAllowed()">
    -          <a href="javascript:void(0);" class="btn btn-link" ng-click="selfCreate()">Self
Registration</a>
    -
    +          <a href="javascript:void(0);" class="btn btn-link" ng-click="selfCreate()">{{
'SELFREGISTRATION' | translate}}</a>
               <!--      <div id="initialLoaderDiv">
    --- End diff --
    
    Can you continue removing such commented code?


> Enduser i18n
> ------------
>
>                 Key: SYNCOPE-721
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-721
>             Project: Syncope
>          Issue Type: New Feature
>          Components: enduser
>            Reporter: Andrea Patricelli
>             Fix For: 2.0.0
>
>
> Add i18n to angular application. It may be useful to export and load once a JSON file
with translated labels and get translations from it at runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message