syncope-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilgrosso <...@git.apache.org>
Subject [GitHub] syncope pull request #21: SYNCOPE-871 Linked NumberWidgets to pages
Date Thu, 16 Jun 2016 13:27:33 GMT
Github user ilgrosso commented on a diff in the pull request:

    https://github.com/apache/syncope/pull/21#discussion_r67343220
  
    --- Diff: client/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java
---
    @@ -170,76 +175,101 @@ private WebMarkupContainer updateRealmContent(final RealmTO realmTO)
{
             if (realmTO == null) {
                 return content;
             }
    -        content.addOrReplace(new Realm("body", realmTO, getPageReference()) {
    +        content.addOrReplace(new RealmConcrete("body", realmTO, getPageReference()));
    +        return content;
    +    }
     
    -            private static final long serialVersionUID = 8221398624379357183L;
    +    private WebMarkupContainer updateRealmContent(final RealmTO realmTO, final int selectedIndex)
{
    +        if (realmTO == null) {
    +            return content;
    +        }
    +        content.addOrReplace(new RealmConcrete("body", realmTO, getPageReference(), selectedIndex));
    +        return content;
    +    }
     
    -            @Override
    -            protected void onClickTemplate(final AjaxRequestTarget target) {
    -                templates.setTargetObject(realmTO);
    -                templates.toggle(target, true);
    -            }
    +    class RealmConcrete extends Realm {
    --- End diff --
    
    I don't understand why you have created `RealmConcrete` instead of putting your additions
directly into `Realm`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message