Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 29D74200ACE for ; Mon, 2 May 2016 15:14:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 28AC51609A1; Mon, 2 May 2016 15:14:15 +0200 (CEST) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4FA3E1609B0 for ; Mon, 2 May 2016 15:14:14 +0200 (CEST) Received: (qmail 39840 invoked by uid 500); 2 May 2016 13:14:13 -0000 Mailing-List: contact dev-help@syncope.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@syncope.apache.org Delivered-To: mailing list dev@syncope.apache.org Received: (qmail 39753 invoked by uid 99); 2 May 2016 13:14:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 May 2016 13:14:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 510142C14F9 for ; Mon, 2 May 2016 13:14:13 +0000 (UTC) Date: Mon, 2 May 2016 13:14:13 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@syncope.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 02 May 2016 13:14:15 -0000 [ https://issues.apache.org/jira/browse/SYNCOPE-798?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D152= 66575#comment-15266575 ]=20 ASF GitHub Bot commented on SYNCOPE-798: ---------------------------------------- Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736265 =20 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/a= pp.js --- @@ -27,394 +29,409 @@ angular.module('info', []); =20 // Declare app level module which depends on views, and components var app =3D angular.module('SyncopeEnduserApp', [ - 'ui.router', - 'ui.bootstrap', - 'ui.select', - 'ngSanitize', - 'ngAnimate', - 'ngResource', - 'ngCookies', - 'treasure-overlay-spinner', - 'ngPasswordStrength', - 'kendo.directives', - 'home', - 'login', - 'language', - 'self', - 'info' + 'ui.router', + 'ui.bootstrap', + 'ui.select', + 'ngSanitize', + 'ngAnimate', + 'ngResource', + 'ngCookies', + 'treasure-overlay-spinner', + 'ngPasswordStrength', + 'kendo.directives', + 'home', + 'login', + 'language', + 'self', + 'info' ]); =20 app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider', - function ($stateProvider, $urlRouterProvider, $httpProvider) { - // route configuration - $stateProvider - .state('home', { - url: '/', - templateUrl: 'views/self.html' - }) - .state('self', { - url: '/self', - templateUrl: 'views/self.html' - }) - .state('user-self-update', { - url: '/user-self-update', - templateUrl: 'views/home.html', - controller: 'HomeController', - resolve: { - 'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); - } - } - }) - .state('create', { - url: '/self/create', - templateUrl: 'views/editUser.html' - }) - // nested states=20 - // each of these sections will have their own view - // url will be nested (/self/create) - .state('create.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html' - }) - .state('create.groups', { - url: '/groups', - templateUrl: 'views/user-groups.html' - }) - .state('create.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html' - }) - .state('create.derivedSchemas', { - url: '/derivedSchemas', - templateUrl: 'views/user-derived-schemas.html' - }) - .state('create.virtualSchemas', { - url: '/virtualSchemas', - templateUrl: 'views/user-virtual-schemas.html' - }) - .state('create.resources', { - url: '/resources', - templateUrl: 'views/user-resources.html' - }) - .state('create.finish', { - url: '/finish', - templateUrl: 'views/user-form-finish.html' - }) - .state('update', { - url: '/self/update', - templateUrl: 'views/editUser.html', - resolve: { - 'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); - } - } - }) - // nested states=20 - // each of these sections will have their own view - // url will be nested (/self/update) - .state('update.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html', - resolve: { - 'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); - } - } - }) - .state('update.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html', - resolve: { - 'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); - } - } - }) - .state('update.derivedSchemas', { - url: '/derivedSchemas', - templateUrl: 'views/user-derived-schemas.html', - resolve: { - 'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); - } - } - }) - .state('update.virtualSchemas', { - url: '/virtualSchemas', - templateUrl: 'views/user-virtual-schemas.html', - resolve: { - 'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); - } - } - }) - .state('update.groups', { - url: '/groups', - templateUrl: 'views/user-groups.html', - resolve: { - 'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); - } - } - }) - .state('update.resources', { - url: '/resources', - templateUrl: 'views/user-resources.html', - resolve: { - 'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); - } - } - }) - .state('update.finish', { - url: '/finish', - templateUrl: 'views/user-form-finish.html', - resolve: { - 'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); - } - } - }) - .state('passwordreset', { - url: '/passwordreset', - templateUrl: 'views/passwordreset.html' - }) - .state('confirmpasswordreset', { - url: '/confirmpasswordreset?token', - templateUrl: 'views/confirmpasswordreset.html' - }) - .state('mustchangepassword', { - url: '/mustchangepassword', - templateUrl: 'views/mustchangepassword.html' - }); + function ($stateProvider, $urlRouterProvider, $httpProvider) { + // route configuration + $stateProvider + .state('home', { + url: '/', + templateUrl: 'views/self.html' + }) + .state('self', { + url: '/self', + templateUrl: 'views/self.html' + }) + .state('user-self-update', { + url: '/user-self-update', + templateUrl: 'views/home.html', + controller: 'HomeController', + resolve: { + 'authenticated': ['AuthService', + function (AuthService) { --- End diff -- =20 Also here: rename `AuthService`. > Once authenticated to enduser, "Cancel" brings nowhere=20 > ------------------------------------------------------- > > Key: SYNCOPE-798 > URL: https://issues.apache.org/jira/browse/SYNCOPE-798 > Project: Syncope > Issue Type: Bug > Components: enduser > Affects Versions: 2.0.0-M2 > Reporter: Francesco Chicchiricc=C3=B2 > Assignee: Matteo Di Carlo > Fix For: 2.0.0 > > Attachments: pointless page.png > > > How to reproduce: > # log into enduser > # hit the red button Cancel on the bottom > # you are redirected to an empty page (see screenshot attached) > Cancel should be equivalent to Logout (so it is really needed? The logout= button is already there). > Incidentally, the same pointless page is returned when accessing /syncope= -enduser if authenticated - which looks wrong, the excepted landing page sh= ould be first one, e.g. "crendentials". -- This message was sent by Atlassian JIRA (v6.3.4#6332)