syncope-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilgrosso <...@git.apache.org>
Subject [GitHub] syncope pull request: SYNCOPE-798 now cancel does logout
Date Mon, 02 May 2016 13:13:53 GMT
Github user ilgrosso commented on a diff in the pull request:

    https://github.com/apache/syncope/pull/13#discussion_r61736276
  
    --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
    @@ -27,394 +29,409 @@ angular.module('info', []);
     
     // Declare app level module which depends on views, and components
     var app = angular.module('SyncopeEnduserApp', [
    -  'ui.router',
    -  'ui.bootstrap',
    -  'ui.select',
    -  'ngSanitize',
    -  'ngAnimate',
    -  'ngResource',
    -  'ngCookies',
    -  'treasure-overlay-spinner',
    -  'ngPasswordStrength',
    -  'kendo.directives',
    -  'home',
    -  'login',
    -  'language',
    -  'self',
    -  'info'
    +    'ui.router',
    +    'ui.bootstrap',
    +    'ui.select',
    +    'ngSanitize',
    +    'ngAnimate',
    +    'ngResource',
    +    'ngCookies',
    +    'treasure-overlay-spinner',
    +    'ngPasswordStrength',
    +    'kendo.directives',
    +    'home',
    +    'login',
    +    'language',
    +    'self',
    +    'info'
     ]);
     
     app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider',
    -  function ($stateProvider, $urlRouterProvider, $httpProvider) {
    -    // route configuration
    -    $stateProvider
    -            .state('home', {
    -              url: '/',
    -              templateUrl: 'views/self.html'
    -            })
    -            .state('self', {
    -              url: '/self',
    -              templateUrl: 'views/self.html'
    -            })
    -            .state('user-self-update', {
    -              url: '/user-self-update',
    -              templateUrl: 'views/home.html',
    -              controller: 'HomeController',
    -              resolve: {
    -                'authenticated': function (AuthenticationHelper) {
    -                  return AuthenticationHelper.authenticated();
    -                }
    -              }
    -            })
    -            .state('create', {
    -              url: '/self/create',
    -              templateUrl: 'views/editUser.html'
    -            })
    -            // nested states 
    -            // each of these sections will have their own view
    -            // url will be nested (/self/create)
    -            .state('create.credentials', {
    -              url: '/credentials',
    -              templateUrl: 'views/user-credentials.html'
    -            })
    -            .state('create.groups', {
    -              url: '/groups',
    -              templateUrl: 'views/user-groups.html'
    -            })
    -            .state('create.plainSchemas', {
    -              url: '/plainSchemas',
    -              templateUrl: 'views/user-plain-schemas.html'
    -            })
    -            .state('create.derivedSchemas', {
    -              url: '/derivedSchemas',
    -              templateUrl: 'views/user-derived-schemas.html'
    -            })
    -            .state('create.virtualSchemas', {
    -              url: '/virtualSchemas',
    -              templateUrl: 'views/user-virtual-schemas.html'
    -            })
    -            .state('create.resources', {
    -              url: '/resources',
    -              templateUrl: 'views/user-resources.html'
    -            })
    -            .state('create.finish', {
    -              url: '/finish',
    -              templateUrl: 'views/user-form-finish.html'
    -            })
    -            .state('update', {
    -              url: '/self/update',
    -              templateUrl: 'views/editUser.html',
    -              resolve: {
    -                'authenticated': function (AuthenticationHelper) {
    -                  return AuthenticationHelper.authenticated();
    -                }
    -              }
    -            })
    -            // nested states 
    -            // each of these sections will have their own view
    -            // url will be nested (/self/update)
    -            .state('update.credentials', {
    -              url: '/credentials',
    -              templateUrl: 'views/user-credentials.html',
    -              resolve: {
    -                'authenticated': function (AuthenticationHelper) {
    -                  return AuthenticationHelper.authenticated();
    -                }
    -              }
    -            })
    -            .state('update.plainSchemas', {
    -              url: '/plainSchemas',
    -              templateUrl: 'views/user-plain-schemas.html',
    -              resolve: {
    -                'authenticated': function (AuthenticationHelper) {
    -                  return AuthenticationHelper.authenticated();
    -                }
    -              }
    -            })
    -            .state('update.derivedSchemas', {
    -              url: '/derivedSchemas',
    -              templateUrl: 'views/user-derived-schemas.html',
    -              resolve: {
    -                'authenticated': function (AuthenticationHelper) {
    -                  return AuthenticationHelper.authenticated();
    -                }
    -              }
    -            })
    -            .state('update.virtualSchemas', {
    -              url: '/virtualSchemas',
    -              templateUrl: 'views/user-virtual-schemas.html',
    -              resolve: {
    -                'authenticated': function (AuthenticationHelper) {
    -                  return AuthenticationHelper.authenticated();
    -                }
    -              }
    -            })
    -            .state('update.groups', {
    -              url: '/groups',
    -              templateUrl: 'views/user-groups.html',
    -              resolve: {
    -                'authenticated': function (AuthenticationHelper) {
    -                  return AuthenticationHelper.authenticated();
    -                }
    -              }
    -            })
    -            .state('update.resources', {
    -              url: '/resources',
    -              templateUrl: 'views/user-resources.html',
    -              resolve: {
    -                'authenticated': function (AuthenticationHelper) {
    -                  return AuthenticationHelper.authenticated();
    -                }
    -              }
    -            })
    -            .state('update.finish', {
    -              url: '/finish',
    -              templateUrl: 'views/user-form-finish.html',
    -              resolve: {
    -                'authenticated': function (AuthenticationHelper) {
    -                  return AuthenticationHelper.authenticated();
    -                }
    -              }
    -            })
    -            .state('passwordreset', {
    -              url: '/passwordreset',
    -              templateUrl: 'views/passwordreset.html'
    -            })
    -            .state('confirmpasswordreset', {
    -              url: '/confirmpasswordreset?token',
    -              templateUrl: 'views/confirmpasswordreset.html'
    -            })
    -            .state('mustchangepassword', {
    -              url: '/mustchangepassword',
    -              templateUrl: 'views/mustchangepassword.html'
    -            });
    +    function ($stateProvider, $urlRouterProvider, $httpProvider) {
    +        // route configuration
    +        $stateProvider
    +                .state('home', {
    +                    url: '/',
    +                    templateUrl: 'views/self.html'
    +                })
    +                .state('self', {
    +                    url: '/self',
    +                    templateUrl: 'views/self.html'
    +                })
    +                .state('user-self-update', {
    +                    url: '/user-self-update',
    +                    templateUrl: 'views/home.html',
    +                    controller: 'HomeController',
    +                    resolve: {
    +                        'authenticated': ['AuthService',
    +                            function (AuthService) {
    +                                return AuthService.islogged()
    +                            }]
    +                    }
    +                })
    +                .state('create', {
    +                    url: '/self/create',
    +                    templateUrl: 'views/editUser.html'
    +                })
    +                // nested states 
    +                // each of these sections will have their own view
    +                // url will be nested (/self/create)
    +                .state('create.credentials', {
    +                    url: '/credentials',
    +                    templateUrl: 'views/user-credentials.html'
    +                })
    +                .state('create.groups', {
    +                    url: '/groups',
    +                    templateUrl: 'views/user-groups.html'
    +                })
    +                .state('create.plainSchemas', {
    +                    url: '/plainSchemas',
    +                    templateUrl: 'views/user-plain-schemas.html'
    +                })
    +                .state('create.derivedSchemas', {
    +                    url: '/derivedSchemas',
    +                    templateUrl: 'views/user-derived-schemas.html'
    +                })
    +                .state('create.virtualSchemas', {
    +                    url: '/virtualSchemas',
    +                    templateUrl: 'views/user-virtual-schemas.html'
    +                })
    +                .state('create.resources', {
    +                    url: '/resources',
    +                    templateUrl: 'views/user-resources.html'
    +                })
    +                .state('create.finish', {
    +                    url: '/finish',
    +                    templateUrl: 'views/user-form-finish.html'
    +                })
    +                .state('update', {
    +                    url: '/self/update',
    +                    templateUrl: 'views/editUser.html',
    +                    resolve: {
    +                            'authenticated': ['AuthService',
    +                            function (AuthService) {
    --- End diff --
    
    Also here: rename `AuthService`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message