syncope-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Francesco Chicchiriccò (Commented) (JIRA) <>
Subject [jira] [Commented] (SYNCOPE-42) Add the ability to delete a user by username via the REST API
Date Tue, 03 Apr 2012 06:36:30 GMT


Francesco Chicchiriccò commented on SYNCOPE-42:

Hi Colm,
the patch seems to work as expected.

Some remarks:
 * UserController.delete(String) can be modified to act as a bare frontend to UserController.delete(Long),
instead of replicating the same code; or a new private delete() method can incapsulate the
logic currently implemented in UserController.delete(Long), and both frontend methods can
delegate to this new one
 * Why UserController.delete(String) does not take input coherently with UserController.delete(Long),
i.e. "/delete?username={username}" instead of "/delete/{username}"?
 * Could you please use a unique (in integration tests context) e-mail address for test user
in UserTestITCase.deleteByUsername()? The one currently used is the same as UserTestITCase.delete()
> Add the ability to delete a user by username via the REST API
> -------------------------------------------------------------
>                 Key: SYNCOPE-42
>                 URL:
>             Project: Syncope
>          Issue Type: Improvement
>    Affects Versions: 1.0.0-incubating
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>             Fix For: 1.0.0-incubating
>         Attachments: syncope-42.patch
> It is currently not possible to delete a user by username via the REST API, only via
the user Id. This task is to add support for this.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message