Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E180B200D10 for ; Sun, 24 Sep 2017 21:59:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E00511609E8; Sun, 24 Sep 2017 19:59:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 30AC41609A7 for ; Sun, 24 Sep 2017 21:59:04 +0200 (CEST) Received: (qmail 80634 invoked by uid 500); 24 Sep 2017 19:59:03 -0000 Mailing-List: contact dev-help@synapse.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@synapse.apache.org Delivered-To: mailing list dev@synapse.apache.org Received: (qmail 80624 invoked by uid 99); 24 Sep 2017 19:59:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Sep 2017 19:59:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AF6B0D00B6 for ; Sun, 24 Sep 2017 19:59:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id zeJceFX4cH7Y for ; Sun, 24 Sep 2017 19:59:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CDEEA5F6C3 for ; Sun, 24 Sep 2017 19:59:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 03D35E0EF6 for ; Sun, 24 Sep 2017 19:59:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4FEC424226 for ; Sun, 24 Sep 2017 19:59:00 +0000 (UTC) Date: Sun, 24 Sep 2017 19:59:00 +0000 (UTC) From: "Vanjikumaran Sivajothy (JIRA)" To: dev@synapse.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (SYNAPSE-306) Merge Hessian and binary message builders/formatters MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 24 Sep 2017 19:59:05 -0000 [ https://issues.apache.org/jira/browse/SYNAPSE-306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vanjikumaran Sivajothy updated SYNAPSE-306: ------------------------------------------- Fix Version/s: (was: 2.0) FUTURE > Merge Hessian and binary message builders/formatters > ---------------------------------------------------- > > Key: SYNAPSE-306 > URL: https://issues.apache.org/jira/browse/SYNAPSE-306 > Project: Synapse > Issue Type: Improvement > Components: Transports > Reporter: Andreas Veithen > Priority: Minor > Fix For: FUTURE > > > SYNAPSE-259 introduced message builders and formatters for the Hessian format: see package org.apache.synapse.format.hessian in module synapse-extensions. > SYNAPSE-261 added builders and formatters for generic binary payloads: see package org.apache.synapse.format in module synapse-transports. > While the code looks very different, those builders and formatters do almost the same thing: the two builders wrap the binary data of the message in a wrapper element using a DataHandler, while the formatters unwrap the data and hand it to the transport. The main differences in behavior are: > * The wrapper element (default) names are different. > * The Hessian message formatter handles SOAP faults in a protocol specific way. > Other differences are technical. For example the Hessian builder uses a TemporaryData object to store the binary data, while BinaryBuilder uses a byte array. Note that using a TemporaryData object would also be beneficial for BinaryBuilder, but this is not possible for the moment given that TemporaryData belongs to synapse-core, while BinaryBuilder is part of synapse-transports. > Given the similarities between the two implementations, the proposal is to merge them as far as possible. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org For additional commands, e-mail: dev-help@synapse.apache.org