synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hiranya Jayathilaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SYNAPSE-954) OCSP/CRL Certificate Validation Feature for Synapse.
Date Wed, 31 Jul 2013 00:13:48 GMT

    [ https://issues.apache.org/jira/browse/SYNAPSE-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724647#comment-13724647
] 

Hiranya Jayathilaka commented on SYNAPSE-954:
---------------------------------------------

I've applied the patch with some modifications. The changes made were:

1. Added the class CertificateVerificationConfig. The verifier config is loaded once from
axis2.xml and stored in an instance of this class instead of reading it for every request.
2. Made SynapseAdaptorForOcspCrl an attribute of the HTTPS sender, instead of creating one
per each request.
3. Made ParentLastClassLoader a static member of the adaptor, instead of creating separate
class loaders per request.
4. Changed the system property synapse.lib to synapse.bcprov.lib. Also this property has been
made optional and not set in synapse.sh by default. When not present, Synapse defaults to
the "lib" directory.
5. Using a FileNameFilter to load the necessary jar files. Removed the version number from
the reference to synapse-nhttp-transport jar.

All the tests and your sample is working fine with the modifications. But I'd like you to
review the changes for verification.

Also I'd appreciate some documentation on this. Please provide a patch to the Synapse transports
catalog under modules/documentation.


===========================================================================================================

For future reference, please stick to the following code conventions when providing patches
for Synapse:

1. Always use curly braces to mark the start and end of code blocks. Avoid writing code like:

if (foo)
   // do something

The correct way is:

if (foo) {
  // do something
}

2. Call isDebugEnabled() before calling log.debug(), especially if the argument to log.debug()
calls other functions and operations. That is avoid this:

log.debug("Before set - HashMap size " + hashMap.size());

Correct way is:

if (log.isDebugEnabled()) {
  log.debug("Before set - HashMap size " + hashMap.size());
}

3. Set the margin in your IDE to 100 characters. That is each line shouldn't exceed the 100
characters mark. It looks like you're currently programming with a margin of 120 characters.
                
> OCSP/CRL Certificate Validation Feature for Synapse.
> ----------------------------------------------------
>
>                 Key: SYNAPSE-954
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-954
>             Project: Synapse
>          Issue Type: New Feature
>          Components: Transports
>    Affects Versions: FUTURE
>         Environment: Linux
>            Reporter: prasad jeewantha
>            Assignee: Hiranya Jayathilaka
>              Labels: security
>             Fix For: FUTURE
>
>         Attachments: certificate_validation.diff, certificate_validation_feature.zip
>
>
> Please find the implementation of the feature along with unit tests and a working sample
in the attached "certificate_validation_feature.zip" file. This feature can be plugged into
both NHTTP and Passthru transports. For more information please read the README.
> Thanks,
> Jeewantha 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


Mime
View raw message