Return-Path: Delivered-To: apmail-synapse-dev-archive@www.apache.org Received: (qmail 91761 invoked from network); 16 Feb 2011 17:20:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 16 Feb 2011 17:20:17 -0000 Received: (qmail 7212 invoked by uid 500); 16 Feb 2011 17:20:16 -0000 Delivered-To: apmail-synapse-dev-archive@synapse.apache.org Received: (qmail 7033 invoked by uid 500); 16 Feb 2011 17:20:14 -0000 Mailing-List: contact dev-help@synapse.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@synapse.apache.org Delivered-To: mailing list dev@synapse.apache.org Received: (qmail 7025 invoked by uid 99); 16 Feb 2011 17:20:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Feb 2011 17:20:13 +0000 X-ASF-Spam-Status: No, hits=3.7 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of hiranya911@gmail.com designates 209.85.216.170 as permitted sender) Received: from [209.85.216.170] (HELO mail-qy0-f170.google.com) (209.85.216.170) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Feb 2011 17:20:08 +0000 Received: by qyk10 with SMTP id 10so4015829qyk.15 for ; Wed, 16 Feb 2011 09:19:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=V1nnY1duR59s2lTEQQM4ozY/Yo+B/841zBmyQVG4Qoo=; b=lMnAaHw+Xad2BUs3N5uwoE2LMD+ZtzeCZWN6Jn0R1i/xsMV17E/R6itPffS1juydhk RGJdc/ndBxjc545U2Im68s4uRCqX5+Ygz2OfvdZD9w96LmDZ7ZbgQuXAEv/uKfZp6VFm vV9BsbN8ruyD4RgRsSRzH5X7Sw6IOd00Ic+90= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=kbUjFxeC37/eBWVImYBxAlFPy3/lu7iPo89Sa8zwtmdcQunO8vQShfAhEexv4QtdfM 76XuDA08JiELsyNtdU5UwovziRsQdkmIVFn++6c6EihXCKmymWhIyvWnsPcwBjFX3YiL HDa6zTvQvHE8J27CR2pOay+NHnV/3ItmZKaac= MIME-Version: 1.0 Received: by 10.229.97.139 with SMTP id l11mr967798qcn.250.1297876787289; Wed, 16 Feb 2011 09:19:47 -0800 (PST) Received: by 10.229.51.221 with HTTP; Wed, 16 Feb 2011 09:19:47 -0800 (PST) In-Reply-To: <20110215183350.DD6B923888D2@eris.apache.org> References: <20110215183350.DD6B923888D2@eris.apache.org> Date: Wed, 16 Feb 2011 22:49:47 +0530 Message-ID: Subject: Re: svn commit: r1071005 - /synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/concurrent/SynapseThreadPool.java From: Hiranya Jayathilaka To: dev@synapse.apache.org Content-Type: multipart/alternative; boundary=0016364eed9ede5e68049c697c7f --0016364eed9ede5e68049c697c7f Content-Type: text/plain; charset=ISO-8859-1 This has caused a build failure. Please take a look. Thanks, Hiranya On Wed, Feb 16, 2011 at 12:03 AM, wrote: > Author: supun > Date: Tue Feb 15 18:33:50 2011 > New Revision: 1071005 > > URL: http://svn.apache.org/viewvc?rev=1071005&view=rev > Log: > changing the thread pool to have the default as a unbounded queue > > Modified: > > synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/concurrent/SynapseThreadPool.java > > Modified: > synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/concurrent/SynapseThreadPool.java > URL: > http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/concurrent/SynapseThreadPool.java?rev=1071005&r1=1071004&r2=1071005&view=diff > > ============================================================================== > --- > synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/concurrent/SynapseThreadPool.java > (original) > +++ > synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/concurrent/SynapseThreadPool.java > Tue Feb 15 18:33:50 2011 > @@ -30,7 +30,7 @@ public class SynapseThreadPool extends T > public static final int SYNAPSE_CORE_THREADS = 20; > public static final int SYNAPSE_MAX_THREADS = 100; > public static final int SYNAPSE_KEEP_ALIVE = 5; > - public static final int SYNAPSE_THREAD_QLEN = 10; > + public static final int SYNAPSE_THREAD_QLEN = -1; > public static final String SYNAPSE_THREAD_GROUP = > "synapse-thread-group"; > public static final String SYNAPSE_THREAD_ID_PREFIX = "SynapseWorker"; > > @@ -81,7 +81,7 @@ public class SynapseThreadPool extends T > public SynapseThreadPool(int corePoolSize, int maxPoolSize, long > keepAliveTime, int qlen, > String threadGroup, String threadIdPrefix) { > super(corePoolSize, maxPoolSize, keepAliveTime, TimeUnit.SECONDS, > - new LinkedBlockingQueue(qlen), > + qlen > 0 ? new LinkedBlockingQueue(qlen) : new > LinkedBlockingDeque(), > new SynapseThreadFactory(new ThreadGroup(threadGroup), > threadIdPrefix)); > } > } > > > -- Hiranya Jayathilaka Senior Software Engineer; WSO2 Inc.; http://wso2.org E-mail: hiranya@wso2.com; Mobile: +94 77 633 3491 Blog: http://techfeast-hiranya.blogspot.com --0016364eed9ede5e68049c697c7f Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable This has caused a build failure. Please take a look.

Tha= nks,
Hiranya

On Wed, Feb 16, 20= 11 at 12:03 AM, <= supun@apache.org> wrote:
Author: supun
Date: Tue Feb 15 18:33:50 2011
New Revision: 1071005

URL: http://svn.apache.org/viewvc?rev=3D1071005&view=3Drev=
Log:
changing the thread pool to have the default as a unbounded queue

Modified:
=A0 =A0synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/ut= il/concurrent/SynapseThreadPool.java

Modified: synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/= util/concurrent/SynapseThreadPool.java
URL: http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/mai= n/java/org/apache/synapse/util/concurrent/SynapseThreadPool.java?rev=3D1071= 005&r1=3D1071004&r2=3D1071005&view=3Ddiff
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D
--- synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/c= oncurrent/SynapseThreadPool.java (original)
+++ synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/c= oncurrent/SynapseThreadPool.java Tue Feb 15 18:33:50 2011
@@ -30,7 +30,7 @@ public class SynapseThreadPool extends T
=A0 =A0 public static final int SYNAPSE_CORE_THREADS =A0=3D 20;
=A0 =A0 public static final int SYNAPSE_MAX_THREADS =A0 =3D 100;
=A0 =A0 public static final int SYNAPSE_KEEP_ALIVE =A0 =A0=3D 5;
- =A0 =A0public static final int SYNAPSE_THREAD_QLEN =A0 =3D 10;
+ =A0 =A0public static final int SYNAPSE_THREAD_QLEN =A0 =3D -1;
=A0 =A0 public static final String SYNAPSE_THREAD_GROUP =A0 =A0 =3D "= synapse-thread-group";
=A0 =A0 public static final String SYNAPSE_THREAD_ID_PREFIX =3D "Syna= pseWorker";

@@ -81,7 +81,7 @@ public class SynapseThreadPool extends T
=A0 =A0 public SynapseThreadPool(int corePoolSize, int maxPoolSize, long k= eepAliveTime, int qlen,
=A0 =A0 =A0 =A0 String threadGroup, String threadIdPrefix) {
=A0 =A0 =A0 =A0 super(corePoolSize, maxPoolSize, keepAliveTime, TimeUnit.S= ECONDS,
- =A0 =A0 =A0 =A0 =A0 =A0new LinkedBlockingQueue<Runnable>(qlen),
+ =A0 =A0 =A0 =A0 =A0 =A0qlen > 0 ? new LinkedBlockingQueue<Runnable&= gt;(qlen) : new LinkedBlockingDeque<Runnable>(),
=A0 =A0 =A0 =A0 =A0 =A0 new SynapseThreadFactory(new ThreadGroup(threadGro= up), threadIdPrefix));
=A0 =A0 }
=A0}





--
Hiranya Jayathilaka
= Senior Software Engineer;
WSO2 Inc.;=A0 http= ://wso2.org
E-mail: hiranya@wso2= .com;=A0 Mobile: +94 77 633 3491
Blog: http://techfeast-hi= ranya.blogspot.com
--0016364eed9ede5e68049c697c7f--