synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From indika kumara <indika.k...@gmail.com>
Subject Re: svn commit: r1071005 - /synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/concurrent/SynapseThreadPool.java
Date Thu, 17 Feb 2011 13:08:34 GMT
I meant we should have done it for 2.0 as there were already API changes
that made 1.x and 2.x incompatible.

~ Indika

On Thu, Feb 17, 2011 at 2:46 PM, indika kumara <indika.kuma@gmail.com>wrote:

> Should it not had been done for 2.0?  We can say 1.x and 2.x not compatible
> but 2 and 2.x ?
>
> ~ Indika
>
>
> On Thu, Feb 17, 2011 at 12:48 PM, Supun Kamburugamuva <supun06@gmail.com>wrote:
>
>> This lead me to thinking, isn't it better to move to the JDK 1.6?
>>
>> Thanks,
>> Supun..
>>
>>
>> On Thu, Feb 17, 2011 at 10:55 AM, Supun Kamburugamuva <supun06@gmail.com>wrote:
>>
>>> Fixed it. Sorry for the trouble.
>>>
>>> Thanks,
>>> Supun..
>>>
>>>
>>> On Wed, Feb 16, 2011 at 10:49 PM, Hiranya Jayathilaka <
>>> hiranya911@gmail.com> wrote:
>>>
>>>> This has caused a build failure. Please take a look.
>>>>
>>>> Thanks,
>>>> Hiranya
>>>>
>>>>
>>>> On Wed, Feb 16, 2011 at 12:03 AM, <supun@apache.org> wrote:
>>>>
>>>>> Author: supun
>>>>> Date: Tue Feb 15 18:33:50 2011
>>>>> New Revision: 1071005
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1071005&view=rev
>>>>> Log:
>>>>> changing the thread pool to have the default as a unbounded queue
>>>>>
>>>>> Modified:
>>>>>
>>>>>  synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/concurrent/SynapseThreadPool.java
>>>>>
>>>>> Modified:
>>>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/concurrent/SynapseThreadPool.java
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/concurrent/SynapseThreadPool.java?rev=1071005&r1=1071004&r2=1071005&view=diff
>>>>>
>>>>> ==============================================================================
>>>>> ---
>>>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/concurrent/SynapseThreadPool.java
>>>>> (original)
>>>>> +++
>>>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/concurrent/SynapseThreadPool.java
>>>>> Tue Feb 15 18:33:50 2011
>>>>> @@ -30,7 +30,7 @@ public class SynapseThreadPool extends T
>>>>>     public static final int SYNAPSE_CORE_THREADS  = 20;
>>>>>     public static final int SYNAPSE_MAX_THREADS   = 100;
>>>>>     public static final int SYNAPSE_KEEP_ALIVE    = 5;
>>>>> -    public static final int SYNAPSE_THREAD_QLEN   = 10;
>>>>> +    public static final int SYNAPSE_THREAD_QLEN   = -1;
>>>>>     public static final String SYNAPSE_THREAD_GROUP     =
>>>>> "synapse-thread-group";
>>>>>     public static final String SYNAPSE_THREAD_ID_PREFIX =
>>>>> "SynapseWorker";
>>>>>
>>>>> @@ -81,7 +81,7 @@ public class SynapseThreadPool extends T
>>>>>     public SynapseThreadPool(int corePoolSize, int maxPoolSize, long
>>>>> keepAliveTime, int qlen,
>>>>>         String threadGroup, String threadIdPrefix) {
>>>>>         super(corePoolSize, maxPoolSize, keepAliveTime,
>>>>> TimeUnit.SECONDS,
>>>>> -            new LinkedBlockingQueue<Runnable>(qlen),
>>>>> +            qlen > 0 ? new LinkedBlockingQueue<Runnable>(qlen)
: new
>>>>> LinkedBlockingDeque<Runnable>(),
>>>>>             new SynapseThreadFactory(new ThreadGroup(threadGroup),
>>>>> threadIdPrefix));
>>>>>     }
>>>>>  }
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Hiranya Jayathilaka
>>>> Senior Software Engineer;
>>>> WSO2 Inc.;  http://wso2.org
>>>> E-mail: hiranya@wso2.com;  Mobile: +94 77 633 3491
>>>> Blog: http://techfeast-hiranya.blogspot.com
>>>>
>>>
>>>
>>>
>>> --
>>> Supun Kamburugamuva
>>> Technical Lead &  Product Manager, WSO2 Inc.; http://wso2.com
>>> Member, Apache Software Foundation; http://www.apache.org
>>>
>>> WSO2 Inc.;  http://wso2.org
>>> E-mail: supun@wso2.com;  Mobile: +94 77 431 3585
>>> Blog: http://supunk.blogspot.com
>>>
>>>
>>>
>>>
>>
>>
>> --
>> Supun Kamburugamuva
>> Technical Lead &  Product Manager, WSO2 Inc.; http://wso2.com
>> Member, Apache Software Foundation; http://www.apache.org
>> WSO2 Inc.;  http://wso2.org
>> E-mail: supun@wso2.com;  Mobile: +94 77 431 3585
>> Blog: http://supunk.blogspot.com
>>
>>
>>
>>
>

Mime
View raw message