Return-Path: Delivered-To: apmail-synapse-dev-archive@www.apache.org Received: (qmail 88235 invoked from network); 15 Dec 2010 14:11:38 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 15 Dec 2010 14:11:38 -0000 Received: (qmail 87916 invoked by uid 500); 15 Dec 2010 14:11:38 -0000 Delivered-To: apmail-synapse-dev-archive@synapse.apache.org Received: (qmail 87735 invoked by uid 500); 15 Dec 2010 14:11:35 -0000 Mailing-List: contact dev-help@synapse.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@synapse.apache.org Delivered-To: mailing list dev@synapse.apache.org Received: (qmail 87728 invoked by uid 99); 15 Dec 2010 14:11:35 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Dec 2010 14:11:35 +0000 X-ASF-Spam-Status: No, hits=1.5 required=10.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of ruwan.linton@gmail.com designates 209.85.216.170 as permitted sender) Received: from [209.85.216.170] (HELO mail-qy0-f170.google.com) (209.85.216.170) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Dec 2010 14:11:31 +0000 Received: by qyk10 with SMTP id 10so6522162qyk.15 for ; Wed, 15 Dec 2010 06:11:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=3kg73nOqQKS14sc5Y+aVEJ0wzb5Cqew6tozrTa6nUEU=; b=RkDlV1Z/Qq/lg+a8FIkyszE83u/7ZbChYndFgj/sHl7JqIzEXAKr7O+vi6ksPacxHk ytMOUDZ7JGisaYKFPnVRVYFdBWyGxuDnPtZCOfEtaiX9ZvmKtKESnZa6Kivb0S/DZV4s YXs6dkMSpYSrNFH95YDX5uU7LrxmaE30NLesM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=UOKPK4TurRk2JhwNcJR/iF3oYlr/RGsAOj5HWi/C5vn5NEu5le36q1xwYD/lgq7HJZ 25Jayzkl1fnHfM9KZ/lb/SFe0MfkdAL0vrjsAUIA7xTqWsZh8ZYFr66OqYwHbzPw1s+C +kIxBlPSe7ywqv3ZJXaEOxwh+kX9zPeswHbwk= MIME-Version: 1.0 Received: by 10.224.20.9 with SMTP id d9mr6310200qab.228.1292422269912; Wed, 15 Dec 2010 06:11:09 -0800 (PST) Received: by 10.220.200.196 with HTTP; Wed, 15 Dec 2010 06:11:09 -0800 (PST) In-Reply-To: References: Date: Wed, 15 Dec 2010 19:41:09 +0530 Message-ID: Subject: Re: [VOTE] Release Synapse-2.0.0 (Take2) From: Ruwan Linton To: dev@synapse.apache.org Content-Type: multipart/alternative; boundary=0015175cba544c45c504977382ca --0015175cba544c45c504977382ca Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Eric, On Thu, Dec 9, 2010 at 4:13 PM, Hubert, Eric wro= te: > Answers inline. Not every statement was meant to describe a =84problem= =93, I > simply always described what I did and what happened. Unexpected behaviou= r > is separately mentioned=85 > ------------------------------ > > > > 1) Synapse startup test with custom 1.2 config > > - config has been put into repository/conf/synapse-config as it seems to > got ignored in repository/conf > > > > I think this is by design and we need to document this on the Upgrading > guide. > > Agreed. > Documented this on the upgrading guide, as the first thing to read when migrating from 1.2 to 2.0 > > > - Synapse does not startup due to a problem in the config (e.g. missing > registry implementation class on the classpath) > > > > I will have a look at this, I guess this needs to be fixed if there is an > issue, can you please give me a small config bit to re-produce this issue= ? > may be you are using a WSO2 ESB registry class shipped with WSO2 which of > course is not available in synapse. :-( > > Yes, my aim was to test a failure case. So it was absolutely expected tha= t > this fails. No issue at all! > > > > - Unexpected behaviour: Although Synapse detects the problems, tries to > perform a clean shutdown, it =93keeps hanging=94 and does not return to t= he > shell with an error return value > > > > Can you please attach the log for this and steps to re-produce, this agai= n > I would like to fix depending on the complexity of the issue... and if th= is > gets slipped from 2.0.0 I suggest immediately spinning a 2.0.1 to fix thi= s > and any other this sort of issues from the 2.0.0 branch. WDYT? > > Yes, I personally do not consider this critical =96 it is simply only not > nice. By the way, the same condition can be reached with many different > issues in a user=92s config. Reproduction is easy. Just specify any class= name > non existing in the classpath e.g. as the registry provider implementatio= n. > It was just a missing exit statement, it does the clean shutdown and just that the thread is not existing. I have fixed this too, on the 2.0 branch, though I was not planning to fix this for the release it happened to be an easy fix. > > > 2) Migration Tool > > - executing the migration tool expects a config in repository/conf (forme= r > config location) > > > > If you type help for the migration tool sh you will find that it is the > default location the script looks for but you can specify your own locati= on > too. > > Maybe it would be slightly better if an no arg execution outputs a usage > instead of assuming the default location and immediately starting to do > something. But this is obviously a matter of taste=85 > I will fix this as this seems more appropriate. > > > - old copy copied there and restarted > > - migration tool modifies config > > - Unexpected behaviour: > > - after migration config stays in repository/conf and needs to be manuall= y > copied to repository/conf/synapse-conf to be recognized > > > > This again is the default location, assuming that you are running the > migration tool for an old configuration, but you could of course give the > new location to be saved after migrating the configuration. I guess we ne= ed > a little bit more documentation around the migration tool. > > > > - migration tool mistakenly removes namespaces (destroying the config), > e.g. > value=3D"tns:Receiver"/> =E0 resultin= g in > startup issues > > > > This we need to fix for this release, I will work on this. > > Great, I=92d also consider this to be a blocker as the migration tool can > convert a working config into a non-working one. I have not checked wheth= er > a backup is saved somewhere=85 > It backs up the original file. I've also fixed this issue. > > > - migration tool removes indentation at the beginning of each xml > element > > > > This is a known issue, but I agree needs to be fixed, since it is not > critical I would live with this for the 2.0.0, but definitely a candidate > for the next version, so we need to raise an issue ticket on the synapse > JIRA for this. > > Agreed, if no one beats me I can do this later today=85 > Will create an issue for this, but I looked for fixing this but couldn't find a way to crack it :-( > > > > > 3) Traditional config in single file versus multi file configuration > > - Unexpected behaviour: > > - replacing dummy synapse.xml with old (converted) config is not enough= , > it results in errors if main and/or fault sequences are used (as the must > exist only once), sequence files need to be removed > > from subdirectories > > > > Yes, this I agree with, but cannot do much I guess again need to explain > this on the Upgrading guide > > Is the reason for this, that no concept has precedence over the other? On= e > can mix both approaches as desired? If so I fully understand, but > documentation is the least we should do. I would also vote for a prominen= t > link to the Upgrading section in the documentation right from the front > page. May under what=92s new or so=85 > Well, my view is it is not so good to neglect the configurations either on synapse.xml nor on the sequences dir and so forth, to me that is a user error and we should fail to start if the failsafe mode is not set. > > > 4) Usage of custom mediators / Site Documentation =93Upgrading=94 > > - In the docu I could not quickly locate a document summarizing the steps > which need to be done to upgrade custom mediators according to API change= s > (I received some AbstractMethodError). I did not check the mediator sourc= es > against the current libraries to find out what is no longer compiling=85. > Anyway a quick summary of API changes would be nice. As long as I haven= =92t > check the points which do not compile I cannot say for sure, whether thos= e > problems are due to the fact that public methods not considered to be par= t > of the public API have been used on our end (which is not unlikely at all= ). > > > > I agree, will try to add more on the API changes, at least for the mediat= or > API. > This is the second and the final task that is remaining... Am trying to get the RC3 out by tomorrow my time, which is within the next 24 hours. Thanks, Ruwan > Great. > > > > > ------------------------------ > > *From:* Ruwan Linton [mailto:ruwan.linton@gmail.com] > *Sent:* Thursday, December 09, 2010 7:04 AM > > > *To:* dev@synapse.apache.org > *Subject:* Re: [VOTE] Release Synapse-2.0.0 (Take2) > > > > So the Sandesha module can be easily removed if you are not doing any > reliable messaging stuff. Just need to delete the file from the > repository/modules directory. I would even remove this error message from > the custom build of Sandesha2 as we any way seem to go for the 3rd round = of > voting. :-) > > > > Eric, I would like to wait for your feedback to do the 3rd RC. So take yo= ur > time, but report us any critical issue as soon as you get to them. May no= t > need to be the complete list, you can report them one by one as and when = you > find those, so that we can fix them if needs to be and be ready for your > next round of the feedback. BTW: must say that we really appreciate your > feedback. > > > > Thanks, > > Ruwan > > > > > -- > Ruwan Linton > Software Architect & Product Manager, WSO2 ESB; http://wso2.org/esb > WSO2 Inc.; http://wso2.org > > Lean . Enterprise . Middleware > > phone: +1 408 754 7388 ext 51789 > email: ruwan@wso2.com; cell: +94 77 341 3097 > blog: http://blog.ruwan.org > linkedin: http://www.linkedin.com/in/ruwanlinton > google: http://www.google.com/profiles/ruwan.linton > tweet: http://twitter.com/ruwanlinton > --=20 Ruwan Linton Software Architect & Product Manager, WSO2 ESB; http://wso2.org/esb WSO2 Inc.; http://wso2.org Lean . Enterprise . Middleware phone: +1 408 754 7388 ext 51789 email: ruwan@wso2.com; cell: +94 77 341 3097 blog: http://blog.ruwan.org linkedin: http://www.linkedin.com/in/ruwanlinton google: http://www.google.com/profiles/ruwan.linton tweet: http://twitter.com/ruwanlinton --0015175cba544c45c504977382ca Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Eric,

On Thu, Dec 9, 2010 at 4:13 PM, = Hubert, Eric <Eric.Hubert@foxmobile.com> wrote:

Answers inline. Not every statement was meant to describe a =84problem=93, I simply always desc= ribed what I did and what happened. Unexpected behaviour is separately mentioned= =85

=A0

1) Synapse startup test with custom 1.2 config

- config has been put into repository/conf/synapse-config as it seems to got ignored in repository/conf

=A0

I think this is by design and we need to document th= is on the Upgrading guide.

Agreed= .

Documented this on the upgrading guide, as the first thing to read whe= n migrating from 1.2 to 2.0
=A0

=A0

- Synapse does not startup due to a problem in the config (e.g. missing registry implementation class on the classpath)

=A0

I will have a look at this, I guess this needs to be= fixed if there is an issue, can you please give me a small config bit to re-produce this issu= e? may be you are using a WSO2 ESB registry class shipped with WSO2 which of course is not available in synapse. :-(

Yes, my aim was to test a failure case. So it was absolutely expected that this fails. No issu= e at all!

=A0

- Unexpected behaviour: Although Synapse detects the problems, tries to perform a clean shutdown, it =93keeps hanging=94 and does not return to the shell with an e= rror return value

=A0

Can you please attach the log for this and steps to = re-produce, this again I would like to fix depending on the complexity of the issue... and i= f this gets slipped from 2.0.0 I suggest immediately spinning a 2.0.1 to fix = this and any other this sort of issues from the 2.0.0 branch. WDYT?

Yes, I personally do not consider this critical =96 it is simply only not nice. By the way, the = same condition can be reached with many different issues in a user=92s config. R= eproduction is easy. Just specify any class name non existing in the classpath e.g. as = the registry provider implementation.

=

It was just a missing exit sta= tement, it does the clean shutdown and just that the thread is not existing= . I have fixed this too, on the 2.0 branch, though I was not planning to fi= x this for the release it happened to be an easy fix.
=A0

=A0

2) Migration Tool

- executing the migration tool expects a config in repository/conf (former config locat= ion)

=A0

If you type help for the migration tool sh you will = find that it is the default location the script looks for but you can specify your own location too.

Maybe it would be slightly better if an no arg execution outputs a usage instead of assuming = the default location and immediately starting to do something. But this is obviously a matter of taste=85


I will fix this as this seems mor= e appropriate.
=A0

=A0

- old copy copied there and restarted

- migration tool modifies config

- Unexpected behaviour:

- after migration config stays in re= pository/conf and needs to be manually copied to repository/conf/synapse-conf to be recognized

=A0

This again is the default location, assuming that yo= u are running the migration tool for an old configuration, but you could of course give the n= ew location to be saved after migrating the configuration. I guess we need a little bit more documentation around the migration tool.

=A0

- migration tool mistakenly removes = namespaces (destroying the config), e.g.
=A0=A0=A0 <code xmlns:tns=3D"http://www.w3.org/2003/05/soap-envelope= " value=3D"tns:Receiver"/> =E0 <syn:code value=3D"tns:Receiver" /> resulting in startup issues

=A0

This we need to fix for this release, I will work on= this.

Great, I=92d also consider this to be a blocker as the migration tool can convert a working config into a non-working one. I have not checked whether a backup is saved somewhere=85


It backs up the original file. I've also fixed = this issue.
=A0

=A0

- migration tool removes indentation= at the beginning of each xml element

=A0

This is a known issue, but I agree needs to be fixed= , since it is not critical I would live with this for the 2.0.0, but definitely a candidate f= or the next version, so we need to raise an issue ticket on the synapse JIRA f= or this.

=A0Agreed, if no one beats me I can do this= later today=85


Will c= reate an issue for this, but I looked for fixing this but couldn't find= a way to crack it :-(
=A0

=A0=

=A0

3) Traditional config in single file versus multi file configuration

- Unexpected behaviour:

=A0 - replacing dummy synapse.xml with old (converted) config is not enough, it results in errors if main and/or fault sequences are used (as the must exis= t only once), sequence files need to be removed=A0

from subdirectories

=A0

Yes, this I agree with, but cannot do much I guess a= gain need to explain this on the Upgrading guide

Is the reason for this, that no concept has precedence over the other? One can mix both approaches = as desired? If so I fully understand, but documentation is the least we should= do. I would also vote for a prominent link to the Upgrading section in the documentation right from the front page. May under what=92s new or so=85


Well, my view is it is not so good to neglect the configurations e= ither on synapse.xml nor on the sequences dir and so forth, to me that is a= user error and we should fail to start if the failsafe mode is not set.
=A0

=A0

4) Usage of custom mediators / Site Documentation =93Upgrading=94

- In the docu I could not quickly locate a document summarizing the steps which need to b= e done to upgrade custom mediators according to API changes (I received some = AbstractMethodError). I did not check the mediator sources against the current libraries to find = out what is no longer compiling=85. Anyway a quick summary of API changes would= be nice. As long as I haven=92t check the points which do not compile I cannot= say for sure, whether those problems are due to the fact that public methods not considered to be part of the public API have been used on our end (which is= not unlikely at all).

=A0

I agree, will try to add more on the API changes, at= least for the mediator API.


This is the second and the final task that i= s remaining...=A0

Am trying to get the RC3 out by = tomorrow my time, which is within the next 24 hours.

Thanks,
Ruwan
=A0

=A0Great.

=A0

=A0

From: Ruwan Linton [mailto:ruwan.linton@gmail.com]
Sent: Thursday, December 09,= 2010 7:04 AM


To: dev@synapse.apache.org
Subject: Re: [VOTE] Release Synapse-2.0.0 (Take2)

=A0

So the Sandesha module can be easily removed if you are not doing any reliable messaging st= uff. Just need to delete the file from the repository/modules directory. I would even remove this error message from the custom build of Sandesha2 as we any= way seem to go for the 3rd round of voting. :-)

=A0

Eric, I would like to wait for your feedback to do the 3rd RC. So take your time, but report u= s any critical issue as soon as you get to them. May not need to be the compl= ete list, you can report them one by one as and when you find those, so that we= can fix them if needs to be and be ready for your next round of the feedback. B= TW: must say that we really appreciate your feedback.

=A0

Thanks,

Ruwan




--
Ruwan Linton
Software Architect & Product Manager, WSO2 ESB; http://wso2.org/esb
WSO2 Inc.; http://wso2.org

Lean . Enterprise . Middleware

phone: +1 408 754 7388 ext 51789
email: ruwan@wso2.com; cell: +94 77 341 3097
blog: http://blog.ruwan= .org
linkedin: http://www.linkedin.com/in/ruwanlinton
google: http://www.google.com/profiles/ruwan.linton
tweet: http://= twitter.com/ruwanlinton




--
Ruwan Linton
Softwar= e Architect & Product Manager, WSO2 ESB; http://wso2.org/esb
WSO2 Inc.; http://wso2.org

Lean . Enterprise . Middleware

phone: +1 408 754 7388 ext 51789<= br>email: ruwan@wso2.co= m; cell: +94 77 341 3097
blog: http://blog.ruwan.org
linkedin: http://www.linkedin.com/in/ruwanlinton
google: http://www.google.= com/profiles/ruwan.linton
tweet: http://= twitter.com/ruwanlinton
--0015175cba544c45c504977382ca--