Return-Path: 
 <dev-return-11897-apmail-synapse-dev-archive=synapse.apache.org@synapse.apache.org>
Delivered-To: apmail-synapse-dev-archive@www.apache.org
Received: (qmail 91408 invoked from network); 28 Apr 2010 16:57:55 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 28 Apr 2010 16:57:55 -0000
Received: (qmail 48563 invoked by uid 500); 28 Apr 2010 16:57:54 -0000
Delivered-To: apmail-synapse-dev-archive@synapse.apache.org
Received: (qmail 48523 invoked by uid 500); 28 Apr 2010 16:57:54 -0000
Mailing-List: contact dev-help@synapse.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@synapse.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@synapse.apache.org>
List-Post: <mailto:dev@synapse.apache.org>
List-Id: <dev.synapse.apache.org>
Reply-To: dev@synapse.apache.org
Delivered-To: mailing list dev@synapse.apache.org
Received: (qmail 48516 invoked by uid 99); 28 Apr 2010 16:57:54 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Apr 2010 16:57:54 +0000
X-ASF-Spam-Status: No, hits=0.1 required=10.0
	tests=AWL,FREEMAIL_FROM,HTML_MESSAGE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of ruwan.linton@gmail.com
 designates 74.125.83.170 as permitted sender)
Received: from [74.125.83.170] (HELO mail-pv0-f170.google.com) (74.125.83.170)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Apr 2010 16:57:49 +0000
Received: by pvc22 with SMTP id 22so270363pvc.15
        for <dev@synapse.apache.org>; Wed, 28 Apr 2010 09:57:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:received:in-reply-to
         :references:date:message-id:subject:from:to:content-type;
        bh=wUDec0+VKNb46/3OVvjq62UHthyn5Yndg4CtYY2Q07Y=;
        b=OWDNtkbrsQDPMTtL56CB0l0PmAGhuMciDTE9iTLeuoK3YTUNpaCbWPdpUrhpoNF5qo
         FD2gx0rk1q/iXF2z7O04R6x+QY+pkMKOgkkaxfqAbyJ03/2wQpTgWzvMjyKpFk7KHa/q
         5fhlOt1UkpiQSFxF9EqkodVG92htGjwWFHBk0=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=RtQBdjVael3el7K+84jVyKzKOGMZJmbkH/Dx5C1IYpW0GWZK6qYu7VXsMHnzYCWSeK
         OQ6B7DQf3zgfDhj8o9GAcbQd6sCnJv9gswuvS82U8lfQrHraHxr7Dxk8bPtmjoPK5EmV
         nCZXEF7emsILaS4UExeJVXW+ggAEJGmPiNohk=
MIME-Version: 1.0
Received: by 10.143.154.28 with SMTP id g28mr4193326wfo.70.1272473849015;
 Wed,
	28 Apr 2010 09:57:29 -0700 (PDT)
Received: by 10.229.12.207 with HTTP; Wed, 28 Apr 2010 09:57:28 -0700 (PDT)
In-Reply-To: <r2l2cbbf7ce1004280659saac719b8gab7789aec935abaf@mail.gmail.com>
References: <r2l2cbbf7ce1004280659saac719b8gab7789aec935abaf@mail.gmail.com>
Date: Wed, 28 Apr 2010 22:27:28 +0530
Message-ID: <i2z672a01201004280957rcaccfefbj460447f56b068f32@mail.gmail.com>
Subject: Re: Synapse ignores registered fault handler if an exception thrown
	in out sequence of a proxy
From: Ruwan Linton <ruwan.linton@gmail.com>
To: dev@synapse.apache.org
Content-Type: multipart/alternative; boundary=001636e0b726c1af2504854ee7fe

--001636e0b726c1af2504854ee7fe
Content-Type: text/plain; charset=ISO-8859-1

Rajika,

This patch has an issue, where it pops the fault handler from the fault
stack, ideally you should get the proxy from the synapse configuration and
get the fault sequence from that and push into the fault stack of inMsgCtx.

Otherwise, if there has been some other fault handler pushed, it will be set
as the fault handler which is wrong.

Thanks,
Ruwan

On Wed, Apr 28, 2010 at 7:29 PM, Rajika Kumarasiri <rajika@wso2.com> wrote:

> Assume the following synapse configuration.
>
> <proxy name="StockQuoteProxy">
>         <target faultSequence="myFaultHandler">
>             <inSequence>
>                <!-- in sequence goes here -->
>             </inSequence>
>             <outSequence>
>                <!-- out sequence goes here -->
>             </outSequence>
>         </target>
>         <publishWSDL
> uri="file:repository/conf/sample/resources/proxy/sample_proxy_1.wsdl"/>
>  </proxy>
>
> <sequence name="myFaultHandler">
>     <!-- fault sequence -->
> </sequence>
>
> It seems that the synapse ignores executing the fault handler
> 'myFaultHandler' when an exception is thrown in outSequence of the proxy
> definition.
> By looking at the code I can see that the registered fault handler only
> take effect in inSequence, reason is the registered fault handler only added
> only into out message context. But when we define a fault handler for the
> proxy it should handle both exceptions occurs in in sequence and out
> sequence.
> I fixed the problem by sharing the defined fault handler in, in message
> context as well ( I have attached the diff). If you agree with the solution
> I can provide this as patch.
>
>
> Rajika
> --
> http://rajikak.blogspot.com/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
> For additional commands, e-mail: dev-help@synapse.apache.org
>



-- 
Ruwan Linton
Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb
WSO2 Inc.; http://wso2.org
email: ruwan@wso2.com; cell: +94 77 341 3097
blog: http://ruwansblog.blogspot.com

--001636e0b726c1af2504854ee7fe
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Rajika,<br><br>This patch has an issue, where it pops the fault handler fro=
m the fault stack, ideally you should get the proxy from the synapse config=
uration and get the fault sequence from that and push into the fault stack =
of inMsgCtx.<br>
<br>Otherwise, if there has been some other fault handler pushed, it will b=
e set as the fault handler which is wrong.<br><br>Thanks,<br>Ruwan<br><br><=
div class=3D"gmail_quote">On Wed, Apr 28, 2010 at 7:29 PM, Rajika Kumarasir=
i <span dir=3D"ltr">&lt;<a href=3D"mailto:rajika@wso2.com">rajika@wso2.com<=
/a>&gt;</span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, =
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Assume the follow=
ing synapse configuration. <br><br>&lt;proxy name=3D&quot;StockQuoteProxy&q=
uot;&gt;<br>
=A0=A0=A0=A0=A0=A0=A0 &lt;target faultSequence=3D&quot;myFaultHandler&quot;=
&gt;<br>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &lt;inSequence&gt;<br>=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &lt;!-- in sequence goes here --&gt;<br>
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &lt;/inSequence&gt;<br>=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0 &lt;outSequence&gt;<br>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0 &lt;!-- out sequence goes here --&gt;<br>=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0 &lt;/outSequence&gt;<br>=A0=A0=A0=A0=A0=A0=A0 &lt;/target&gt;<br>=A0=
=A0=A0=A0=A0=A0=A0 &lt;publishWSDL uri=3D&quot;file:repository/conf/sample/=
resources/proxy/sample_proxy_1.wsdl&quot;/&gt;<br>

=A0&lt;/proxy&gt;<br><br>&lt;sequence name=3D&quot;myFaultHandler&quot;&gt;=
<br>=A0=A0=A0 &lt;!-- fault sequence --&gt;<br>&lt;/sequence&gt;<br clear=
=3D"all"><br>It seems that the synapse ignores executing the fault handler =
&#39;myFaultHandler&#39; when an exception is thrown in outSequence of the =
proxy definition. <br>

By looking at the code I can see that the registered fault handler only tak=
e effect in inSequence, reason is the registered fault handler only added o=
nly into out message context. But when we define a fault handler for the pr=
oxy it should handle both exceptions occurs in in sequence and out sequence=
. <br>

I fixed the problem by sharing the defined fault handler in, in message con=
text as well ( I have attached the diff). If you agree with the solution I =
can provide this as patch.<br><br><br>Rajika<br><font color=3D"#888888">-- =
<br>
<a href=3D"http://rajikak.blogspot.com/" target=3D"_blank">http://rajikak.b=
logspot.com/</a><br>

</font><br><br>
---------------------------------------------------------------------<br>
To unsubscribe, e-mail: <a href=3D"mailto:dev-unsubscribe@synapse.apache.or=
g">dev-unsubscribe@synapse.apache.org</a><br>
For additional commands, e-mail: <a href=3D"mailto:dev-help@synapse.apache.=
org">dev-help@synapse.apache.org</a><br></blockquote></div><br><br clear=3D=
"all"><br>-- <br>Ruwan Linton<br>Technical Lead &amp; Product Manager; WSO2=
 ESB; <a href=3D"http://wso2.org/esb">http://wso2.org/esb</a><br>
WSO2 Inc.; <a href=3D"http://wso2.org">http://wso2.org</a><br>email: <a hre=
f=3D"mailto:ruwan@wso2.com">ruwan@wso2.com</a>; cell: +94 77 341 3097<br>bl=
og: <a href=3D"http://ruwansblog.blogspot.com">http://ruwansblog.blogspot.c=
om</a> <br>


--001636e0b726c1af2504854ee7fe--