Return-Path: Delivered-To: apmail-synapse-dev-archive@www.apache.org Received: (qmail 37813 invoked from network); 11 Jun 2009 10:57:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 11 Jun 2009 10:57:27 -0000 Received: (qmail 41722 invoked by uid 500); 11 Jun 2009 10:57:38 -0000 Delivered-To: apmail-synapse-dev-archive@synapse.apache.org Received: (qmail 41626 invoked by uid 500); 11 Jun 2009 10:57:38 -0000 Mailing-List: contact dev-help@synapse.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@synapse.apache.org Delivered-To: mailing list dev@synapse.apache.org Received: (qmail 41618 invoked by uid 99); 11 Jun 2009 10:57:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jun 2009 10:57:38 +0000 X-ASF-Spam-Status: No, hits=2.7 required=10.0 tests=FROM_LOCAL_NOVOWEL,HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of prgtrdr@gmail.com designates 209.85.132.248 as permitted sender) Received: from [209.85.132.248] (HELO an-out-0708.google.com) (209.85.132.248) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jun 2009 10:57:28 +0000 Received: by an-out-0708.google.com with SMTP id c37so709489anc.6 for ; Thu, 11 Jun 2009 03:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=RzBu8ThhXTZ8+Msi5tg0wgPsOwZaYmun+QU+ORVj6nY=; b=VNPwLnLTRaY4DcLqwZMv74w8OgzajF8cJy4PgDbnGus0MnPjHiB3RQkyQpklKMZw+p s/TXTrebzDLSKNvdRRVJlq44EvrYFgiD7UR/cW7EjwidHl9RZmwFeKEy39kTVEpJz0wV 7q0nlX2whgbZuOCuyLY7MDjkKJjI2PvzNATTY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=eXMiYEGb+AnF8yWFlcz/amHflFIKtSzMbmgnssuRNE9MHVPzH0qDT1UdobRKE7hIh/ HPpjPFHJN0EKJKurgTFfrxPOENgPRpRwae4rPVpTzNNst6LRRvEaW5hshVyOg9QHJUL6 SP/0fKYzdc13fSP1grYGfo4SWtGER9nW0oxcA= MIME-Version: 1.0 Received: by 10.100.132.14 with SMTP id f14mr2677075and.79.1244717827533; Thu, 11 Jun 2009 03:57:07 -0700 (PDT) In-Reply-To: <17d2d1290906110342r3c51cf7el7e2c7cc876af6ad0@mail.gmail.com> References: <7bd8d0620906100440p14464ea9j2c3f7c055901a60a@mail.gmail.com> <4A30CF19.7040403@apache.org> <17d2d1290906110342r3c51cf7el7e2c7cc876af6ad0@mail.gmail.com> Date: Thu, 11 Jun 2009 06:57:07 -0400 Message-ID: <7bd8d0620906110357o522a0c0ek10bd2ca9d5c2e9c9@mail.gmail.com> Subject: Re: XPath doesn't return attribute value From: Bill Harts To: dev@synapse.apache.org Content-Type: multipart/alternative; boundary=0016e6434bccf4affa046c10734b X-Virus-Checked: Checked by ClamAV on apache.org --0016e6434bccf4affa046c10734b Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi Saliya: Thanks for pointing this out. It saves making a change to Axis2/Axiom. Congrats on being made a committer! Regards, Bill On Thu, Jun 11, 2009 at 6:42 AM, Saliya Ekanayake wrote: > > Hi Bill, > > OMAttributeEx implements OMAttribute interface. So you may check instance > of OMAttribute. This way you don't have to change access modifiers. Also > additional imports are not necessary. > > Thanks, > Saliya > > > On Thu, Jun 11, 2009 at 3:02 PM, Asankha C. Perera wrote: > >> Hi Bill >> >> .... >> *Solution:* >> I added the following code to synapseXpath.java::stringValueOf at line >> 206: >> ... >> } else if (o instanceof OMAttributeEx) { >> textValue.append( >> ((OMAttributeEx)o).getAttributeValue()); >> } >> ... >> >> Also, since the type OMAttributeEx is an inner class of type >> DocumentNavigator I needed to add an import statement in SynapseXPath.java: >> >> import org.apache.axiom.om.xpath.DocumentNavigator.OMAttributeEx; >> >> Unfortunately, OMAtributeEx is defined as private to class >> DocumentNavigator so I had to declare class and constructor OMAttributeEx as >> public in the module DocumentNavigator.java in the Axiom project module >> axiom-api.jar. >> >> If someone can point me to instructions for how to create a patch I will >> post one here. >> >> I think your solution is correct.. if your question is "how to create a >> patch with svn?".. you should go to the project root, and issue "svn diff > >> changes.patch" and attach this patch to a JIRA (selecting that you grant the >> Apache foundation the rights to use the code).. then one of the comitters of >> the relevant project (Synapse, Axiom etc) will apply the patch to the >> codebase >> >> cheers >> asankha >> >> -- >> Asankha C. Perera >> AdroitLogic, http://adroitlogic.org >> http://esbmagic.blogspot.com >> >> >> > > > -- > Saliya Ekanayake > http://www.esaliya.blogspot.com > http://www.esaliya.wordpress.com > --0016e6434bccf4affa046c10734b Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Saliya:

Thanks for pointing this out.=A0 It saves making a change= to Axis2/Axiom.

Congrats on being made a committer!

Regards,=
Bill

On Thu, Jun 11, 2009 at 6:42 AM,= Saliya Ekanayake <esaliya@gmail.com> wrote:

Hi Bill,
<= br>OMAttributeEx implements OMAttribute interface. So you may check instanc= e of OMAttribute. This way you don't have to change access modifiers. A= lso additional imports are not necessary.

Thanks,
Saliya


= On Thu, Jun 11, 2009 at 3:02 PM, Asankha C. Perera <asankha@apache.org> wrote:
=20
Hi Bill
....

Solution:
I added the following code to synapseXpath.java::stringValueOf at line 206:
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ...
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 } else if (o inst= anceof OMAttributeEx) {
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 textV= alue.append( ((OMAttributeEx)o).getAttributeValue());
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 }
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ...

Also, since the type OMAttributeEx is an inner class of type DocumentNavigator I needed to add an import statement in SynapseXPath.java:

import org.apache.axiom.om.xpath.DocumentNavigator.OMAttributeEx;

Unfortunately, OMAtributeEx is defined as private to class DocumentNavigator so I had to declare class and constructor OMAttributeEx as public in the module DocumentNavigator.java in the Axiom project module axiom-api.jar.=A0

If someone can point me to instructions for how to create a patch I will post one here.
I think your solution is correct.. if your question is "how to create = a patch with svn?".. you should go to the project root, and issue "= svn diff > changes.patch" and attach this patch to a JIRA (selecting that you grant the Apache foundation the rights to use the code).. then one of the comitters of the relevant project (Synapse, Axiom etc) will apply the patch to the codebase


cheers
asankha
--=20
Asankha C. Perera
AdroitLogic, http://ad=
roitlogic.org

http://esbmagic.=
blogspot.com



--
Saliya Ekanayake
http://www.esaliya.blogspot.com
http://www.esaliya.wordpress= .com

--0016e6434bccf4affa046c10734b--