Return-Path: Delivered-To: apmail-synapse-dev-archive@www.apache.org Received: (qmail 87488 invoked from network); 1 May 2009 11:01:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 1 May 2009 11:01:49 -0000 Received: (qmail 90398 invoked by uid 500); 1 May 2009 11:01:49 -0000 Delivered-To: apmail-synapse-dev-archive@synapse.apache.org Received: (qmail 90317 invoked by uid 500); 1 May 2009 11:01:49 -0000 Mailing-List: contact dev-help@synapse.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@synapse.apache.org Delivered-To: mailing list dev@synapse.apache.org Received: (qmail 90305 invoked by uid 99); 1 May 2009 11:01:48 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 May 2009 11:01:48 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of ruwan.linton@gmail.com designates 209.85.142.190 as permitted sender) Received: from [209.85.142.190] (HELO ti-out-0910.google.com) (209.85.142.190) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 May 2009 11:01:38 +0000 Received: by ti-out-0910.google.com with SMTP id a6so253602tib.15 for ; Fri, 01 May 2009 04:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=8JQ0vRQdJmzEKBJxKJeaR0PK/FBC9bl+YG/PZzmVyYU=; b=VRzx379culKVGpP7qznNTXz+S+NPtZnlnm+Vs3tDIhx6WLQbYEzMgyMsdHEVtirrLz lZagH9nhoLNMcI+uieN4vEnbZga6BKd7fQ9FIad6w00AqcsCB/utU9E45PsYsDTEEiHp VL8qhMiuKrLFYWNciLSsTg20LHtLcId2yheao= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=SRUpcN5MKOqDn53J+G6cFDN4kfwgq4u7nMvjpa/TvPKW6AJ12Y9InaMeoB1iQ8ccJT BuyHPx6jTFW9/Pfl3e7bSjajJ82l/YbYkpQE4pGM6sonpp+iYKUwIoA2yumO/XmBTsqk 2cXyOyrGPQegG2CqcamSMvrnLv31pR+kN3184= MIME-Version: 1.0 Received: by 10.110.95.3 with SMTP id s3mr205848tib.37.1241175675155; Fri, 01 May 2009 04:01:15 -0700 (PDT) In-Reply-To: <12AEA201F6668F4AAA121035CCFEEB1A502C1E@berwnexmb06.jcorp.ad.jamba.net> References: <1466537773.1240699890341.JavaMail.jira@brutus> <12AEA201F6668F4AAA121035CCFEEB1A5029C9@berwnexmb06.jcorp.ad.jamba.net> <672a01200904261110r1cb03457u46ef4477469e4e5e@mail.gmail.com> <672a01200904261211p7d9ff9d0q66662f6091524b45@mail.gmail.com> <12AEA201F6668F4AAA121035CCFEEB1A5029CA@berwnexmb06.jcorp.ad.jamba.net> <49F5B05A.5090709@apache.org> <12AEA201F6668F4AAA121035CCFEEB1A502A6E@berwnexmb06.jcorp.ad.jamba.net> <12AEA201F6668F4AAA121035CCFEEB1A502BB3@berwnexmb06.jcorp.ad.jamba.net> <672a01200904302055o4d785270uacdea75eb3b3ec7d@mail.gmail.com> <12AEA201F6668F4AAA121035CCFEEB1A502C1E@berwnexmb06.jcorp.ad.jamba.net> Date: Fri, 1 May 2009 16:31:14 +0530 Message-ID: <672a01200905010401o1c08b045t5d14217aa3f05fb0@mail.gmail.com> Subject: Re: [jira] Updated: (SYNAPSE-536) Error while stoping the Synapse server From: Ruwan Linton To: dev@synapse.apache.org Content-Type: multipart/alternative; boundary=0016e64fcc8838bc030468d7bb0c X-Virus-Checked: Checked by ClamAV on apache.org --0016e64fcc8838bc030468d7bb0c Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Sure... i already seen the comment and will resolve that as well :-) Thanks, Ruwan On Fri, May 1, 2009 at 3:51 PM, Hubert, Eric wro= te: > Hi Ruwan, > > > > hope you have fully recovered. While reviewing my patch, please also noti= ce > my comment on SYNAPSE-538. > > > > Regards, > > Eric > > > ------------------------------ > > *From:* Ruwan Linton [mailto:ruwan.linton@gmail.com] > *Sent:* Friday, May 01, 2009 5:56 AM > > *To:* dev@synapse.apache.org > *Subject:* Re: [jira] Updated: (SYNAPSE-536) Error while stoping the > Synapse server > > > > Hi Eric, > > I was having a serious flue and was unable to work at all. I will have a > look and will take care of this. > > Thanks, > Ruwan > > On Thu, Apr 30, 2009 at 11:42 AM, Hubert, Eric > wrote: > > Ruwan, did you find time to review this patch? I=92m a bit concerned the > patch could get invalid due to other changes to some of the rather centra= l > classes and would need additional update effort. > > > ------------------------------ > > *From:* Hubert, Eric [mailto:Eric.Hubert@foxmobile.com] > *Sent:* Monday, April 27, 2009 9:16 PM > > > *To:* dev@synapse.apache.org > > *Subject:* RE: [jira] Updated: (SYNAPSE-536) Error while stoping the > Synapse server > > > > Hi all, > > > > Asankha, thanks for taking a high-level look on the patch. I would also > feel much more comfortable if Ruwan could take an additional low-level lo= ok > at the patch. ;-) > > I spent a couple of hours doing those changes spread of several days in > which also other changes had been applied to the same classes, so I neede= d > to update my working copy several times to catch up. I hope no change > slipped through. > > I also did some method renaming and removed unnecessary indirections to > make the code more readable. There is still room for improvements, but I > wanted to get out the first chunk to not have to update too frequently du= e > to parallel changes. > > > > Regards, > > Eric > > > ------------------------------ > > *From:* Asankha Perera [mailto:asankha.apache@gmail.com] *On Behalf Of *A= sankha > C. Perera > *Sent:* Monday, April 27, 2009 3:17 PM > *To:* dev@synapse.apache.org > *Subject:* Re: [jira] Updated: (SYNAPSE-536) Error while stoping the > Synapse server > > > > Hi Eric > > I submitted my patch in a new JIRA ( > https://issues.apache.org/jira/browse/SYNAPSE-537) as could not locate th= e > existing issue. Maybe Asankha can help out. > > I hope someone finds time to review. > > > > Afterwards I will go through all the known issues on my list regarding th= e > shutdown handling. Ruwan, if you can provide more details or stack trace = I > will be happily jump in and help once I find the time - next weekend at t= he > latest. > > I've done a brief look at the changes, and they seem ok to me at a high > level. I think Ruwan should ok this as well with the recent changes he ha= s > been doing on the stop/restart logic. > > thanks > asankha > > -- > > Asankha C. Perera > > AdroitLogic, http://adroitlogic.org > > > > http://esbmagic.blogspot.com > > > > > > > > > > > -- > Ruwan Linton > Senior Software Engineer & Product Manager; WSO2 ESB; http://wso2.org/esb > WSO2 Inc.; http://wso2.org > email: ruwan@wso2.com; cell: +94 77 341 3097 > blog: http://ruwansblog.blogspot.com > --=20 Ruwan Linton Senior Software Engineer & Product Manager; WSO2 ESB; http://wso2.org/esb WSO2 Inc.; http://wso2.org email: ruwan@wso2.com; cell: +94 77 341 3097 blog: http://ruwansblog.blogspot.com --0016e64fcc8838bc030468d7bb0c Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Sure... i already seen the comment and will resolve that as well :-)
Thanks,
Ruwan

On Fri, May 1, 2009 at = 3:51 PM, Hubert, Eric <Eric.Hubert@foxmobile.com> wrote:

Hi Ruwan,

=A0

hope you have fully recovered. While reviewing my patch, please also notice my comment on SYNAP= SE-538.

=A0

Regards,

=A0=A0 Eric<= /font>

=A0

From: Ru= wan Linton [mailto:ruwan.l= inton@gmail.com]
Sent: Friday, May 01, 2009= 5:56 AM


To: dev@synapse.apache.org
Subject: Re: [jira] Update= d: (SYNAPSE-536) Error while stoping the Synapse server

=A0

Hi Eric,

I was having a serious flue and was unable to work at all. I will have a lo= ok and will take care of this.

Thanks,
Ruwan

On Thu, Apr 30, 2009 at 11:42 AM, Hubert, Eric <Eric.Hubert@foxmobile.com> wrote:

Ruwan, did you find= time to review this patch? I=92m a bit concerned the patch could get invalid due to other changes to s= ome of the rather central classes and would need additional update effort.<= /font>

=A0

From: Hu= bert, Eric [mailto:Eric.Hubert@foxmobile.com]
Sent: Monday, April 27, 20= 09 9:16 PM

Subject:=A0

Hi all,

=A0

Asankha, thanks for= taking a high-level look on the patch. I would also feel much more comfortable if Ruwan could take an additional low-level look at the patch. ;-)

I spent a couple of= hours doing those changes spread of several days in which also other changes had been applied to the = same classes, so I needed to update my working copy several times to catch up. I hope no change slipped through.

I also did some met= hod renaming and removed unnecessary indirections to make the code more readable. There is still roo= m for improvements, but I wanted to get out the first chunk to not have to up= date too frequently due to parallel changes.

=A0

Regards,

=A0=A0 Eric<= /font>

=A0

From: As= ankha Perera [mailto:asankha.apache@gmail.com] On Behalf Of Asankha C. Pe= rera
Sent: Monday, April 27, 20= 09 3:17 PM
To: dev@synapse.apache.org
Subject: Re: [jira] Update= d: (SYNAPSE-536) Error while stoping the Synapse server

=A0

Hi Eric

I submitted my patc= h in a new JIRA (https://issues.apache.org/jira/browse/SYNAPSE-537) as could not locate the existing issue. Maybe Asankha can help out.

I hope someone find= s time to review.

=A0

Afterwards I will g= o through all the known issues on my list regarding the shutdown handling. Ruwan, if you can provide more details or stack trace I will be happily jump in and help once I find the t= ime - next weekend at the latest.

I've do= ne a brief look at the changes, and they seem ok to me at a high level. I think Ruwan should ok this as well wi= th the recent changes he has been doing on the stop/restart logic.

thanks
asankha

-- 
Asankha C. Perera
AdroitLogic, http://adroitlogic.org
=A0
http://esbmagic.blogspot.com
=A0
=A0
=A0




--
Ruwan Linton
Senior Software Engineer & Product Manager; WSO2 ESB; http://wso2.org/esb
WSO2 Inc.; http://wso2.org
email: ruwan@wso2.com; cell: +94 77 341 3097
blog: http://r= uwansblog.blogspot.com




--
Ruwan Linton
Senior = Software Engineer & Product Manager; WSO2 ESB; http://wso2.org/esb
WSO2 Inc.; h= ttp://wso2.org
email: ruwan@wso2.com; cell: +94 77 3= 41 3097
blog: http://ruwansbl= og.blogspot.com
--0016e64fcc8838bc030468d7bb0c--