synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ruwan Linton" <ruwan.lin...@gmail.com>
Subject Re: Committing patch contributed for MIME message parser and serializer based on Apache mime4j [WSCOMMONS-387]
Date Thu, 20 Nov 2008 14:24:21 GMT
Dims,

I am sorry, I cannot find the reasoning that you are referring. Now that
Oleg did the differed passing part that Thilina suggested, I think it is in
a good shape.

If I am missing anything, can you please explain the reason of not
committing this patch?

Thanks,
Ruwan

On Thu, Nov 20, 2008 at 7:29 PM, Davanum Srinivas <davanum@gmail.com> wrote:

> Please see my previous emails.
>
> -- dims
>
> On Thu, Nov 20, 2008 at 8:48 AM, Sanjiva Weerawarana
> <sanjiva@opensource.lk> wrote:
> > For what reason? If you decide to veto then you should have the courtesy
> to
> > give a reason.
> >
> > Sanjiva.
> >
> > Davanum Srinivas wrote:
> >>
> >> -1 to checking in the patch as-is.
> >>
> >> thanks,
> >> dims
> >>
> >> On Thu, Nov 20, 2008 at 8:23 AM, Sanjiva Weerawarana
> >> <sanjiva@opensource.lk> wrote:
> >>>
> >>> Oleg Kalnichevski wrote:
> >>>>
> >>>> I have commit rights for Synapse, but I do not recall ever being
> granted
> >>>> WS commit rights.
> >>>
> >>> With the transport move you do now.
> >>>
> >>> Thilina, while I agree with "don't fix if it ain't broke", this is an
> >>> *improvement* .. not a fix for the sake of a fix. I think we should do
> >>> it.
> >>>
> >>> If it breaks something (like interop) we can always revert ..
> >>>
> >>> Sanjiva.
> >>> --
> >>> Sanjiva Weerawarana, Ph.D.
> >>> Founder & Director; Lanka Software Foundation;
> http://www.opensource.lk/
> >>> Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
> >>> Member; Apache Software Foundation; http://www.apache.org/
> >>> Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/
> >>>
> >>> Blog: http://sanjiva.weerawarana.org/
> >>>
> >>
> >>
> >>
> >
> >
> > --
> > Sanjiva Weerawarana, Ph.D.
> > Founder & Director; Lanka Software Foundation; http://www.opensource.lk/
> > Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
> > Member; Apache Software Foundation; http://www.apache.org/
> > Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/
> >
> > Blog: http://sanjiva.weerawarana.org/
> >
>
>
>
> --
> Davanum Srinivas :: http://davanum.wordpress.com
>



-- 
Ruwan Linton
http://wso2.org - "Oxygenating the Web Services Platform"
http://ruwansblog.blogspot.com/

Mime
View raw message