synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Veithen (JIRA)" <>
Subject [jira] Commented: (SYNAPSE-246) Inappropriate test strategy in MailEchoRawXMLTest
Date Sat, 03 May 2008 21:00:56 GMT


Andreas Veithen commented on SYNAPSE-246:

Changed the unit tests to use mock JavaMail store and transport providers so that they no
longer depend on GMail. This solves the issue, but still need to:
* clean up (in particular remove duplicate code!!);
* add documentation.

> Inappropriate test strategy in MailEchoRawXMLTest
> -------------------------------------------------
>                 Key: SYNAPSE-246
>                 URL:
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: NIGHTLY
>            Reporter: Andreas Veithen
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: FUTURE
> The unit tests in MailEchoRawXMLTest test the mail transport by sending mails to a Gmail
account, connecting to and This strategy is inappropriate for
several reasons:
> 1) It introduces a dependency external to the test itself.
> 2) The tests will fail when executed on a machine not connected to the Internet or from
within a network with a restrictive firewall.
> 3) It slows down the execution of the tests.
> 4) Sporadically replies with "421 4.4.5 Server busy, try again later.",
causing the test to fail.
> Maybe we should consider using something like mock-javamail (
to make these tests self-containing.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message