synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Veithen (JIRA)" <>
Subject [jira] Commented: (SYNAPSE-218) TextFileDataSource violates OMDataSource contract
Date Mon, 28 Apr 2008 19:39:57 GMT


Andreas Veithen commented on SYNAPSE-218:

* The two serialize methods have been modified to solve points 1 and 2. These changes will
be committed once write access to is enabled again.
* Point 3 has been solved in revision #640431 by implementing OMDataSourceExt and making it
non destructive.
* The changes in revision #639062 make sure that VFSTransportSender (and also MailTransportSender)
no longer rely on the behavior described in point 1.
* For the logging issue: currently the entire text data is always dumped, but this is not
(only) related to the behavior of the serialize(Writer, OMOutputFormat) method. Since dumping
the entire content will cause problems for very large messages, a new issue will be opened
for this.

> TextFileDataSource violates OMDataSource contract
> -------------------------------------------------
>                 Key: SYNAPSE-218
>                 URL:
>             Project: Synapse
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: NIGHTLY
>            Reporter: Andreas Veithen
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: 1.2
> TextFileDataSource is an implementation of OMDataSource representing text wrapped inside
a <text> element. However, it doesn't respect the contract of OMDataSource:
> 1) serialize(OutputStream, OMOutputFormat) doesn't output the <text> wrapper element
(actually the code is commented out) and doesn't take into account the character encoding
specified by the OMOutputFormat.
> 2) serialize(Writer, OMOutputFormat) only outputs an empty <text> element.
> 3) TextFileDataSource will give unexpected results with multiple invocations (of the
same or different methods) on the same instance, because the invocation of any of the methods
consumes the InputStream.
> It should be noted that
> * VFSTransportSender relies on the behavior described in point 1;
> * the intention of the behavior described in point 2 is probably to avoid dumping the
entire text data when the message is logged.
> However, the described behavior might lead to unexpected results in other situations.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message