synapse-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Fremantle" <pzf...@gmail.com>
Subject Re: [axis2] Heads-up - AxisEngine work
Date Fri, 11 May 2007 11:06:02 GMT
Glen

Can you please copy Synapse-dev as well on these notes.. we use a lot
of core Axis2 engine code in our Axis2 environment.

Paul

On 5/10/07, Glen Daniels <glen@thoughtcraft.com> wrote:
> Hi folks!
>
> Cleaning up some logic in AxisEngine and related areas.
>
> There are a bunch of places where you'll see this code scattered around:
>
>     if (msgContext.getEnvelope().getBody.hasFault()) {
>       axisEngine.receiveFault(msgContext);
>     } else {
>       axisEngine.receive(msgContext);
>     }
>
> If you go look at AxisEngine.receive() vs. AxisEngine.receiveFault()
> they are almost identical.  In other words, there is a bunch of repeated
> code and an opportunity for things to get out of sync.
>
> Also, the above code is just silly to have repeated all over the place,
> and it really shouldn't be something a transport author should need to
> worry about.
>
> Hence, I'm removing AxisEngine.receiveFault() and making receive() do
> the above check before deciding which flow (IN or IN_FAULT) to use.  The
> check also will become MessageContext.isFault() instead of having to dig
> into the SOAP body - let the MC do that.
>
> I will very likely be doing the same with send()/sendFault(), since I
> believe there's a similar issue there.
>
> Thanks,
> --Glen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>


-- 
Paul Fremantle
VP/Technology, WSO2 and OASIS WS-RX TC Co-chair

http://bloglines.com/blog/paulfremantle
paul@wso2.com

"Oxygenating the Web Service Platform", www.wso2.com

---------------------------------------------------------------------
To unsubscribe, e-mail: synapse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: synapse-dev-help@ws.apache.org


Mime
View raw message