superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [superset] suddjian opened a new pull request #16073: fix(explore): drag & drop column select component triggering onChange unnecessarily
Date Thu, 05 Aug 2021 11:11:02 GMT

suddjian opened a new pull request #16073:
URL: https://github.com/apache/superset/pull/16073


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Fixes #16016
   
   The example had a value for the `granularity_sqla` field that was not found in the dataset.
When that happens, the mechanism that is meant to detect changes in dataset thinks that there
has been a change. The fix for this is to only begin checking for dataset changes after the
first render.
   
   ### AFTER
   <!--- Skip this if not applicable -->
   <img width="1095" alt="Screen Shot 2021-08-04 at 1 48 46 PM" src="https://user-images.githubusercontent.com/1858430/128252795-acdeb355-25ef-4a1b-af7e-5eb404add34e.png">
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   Open the Calendar Heatmap example chart.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #16016
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message