From notifications-return-108914-archive-asf-public=cust-asf.ponee.io@superset.apache.org  Tue Jul 13 01:54:12 2021
Return-Path: <notifications-return-108914-archive-asf-public=cust-asf.ponee.io@superset.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255])
	by mx-eu-01.ponee.io (Postfix) with ESMTPS id 4CB7F180679
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 13 Jul 2021 03:54:12 +0200 (CEST)
Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153])
	by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 441353F4CB
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 13 Jul 2021 01:54:07 +0000 (UTC)
Received: (qmail 63352 invoked by uid 500); 13 Jul 2021 01:54:06 -0000
Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@superset.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@superset.apache.org>
List-Post: <mailto:notifications@superset.apache.org>
List-Id: <notifications.superset.apache.org>
Reply-To: dev@superset.apache.org
Delivered-To: mailing list notifications@superset.apache.org
Received: (qmail 63342 invoked by uid 99); 13 Jul 2021 01:54:06 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jul 2021 01:54:06 +0000
From: =?utf-8?q?GitBox?= <git@apache.org>
To: notifications@superset.apache.org
Subject: =?utf-8?q?=5BGitHub=5D_=5Bsuperset=5D_eschutho_commented_on_a_change_in_pull?=
 =?utf-8?q?_request_=2315598=3A_feat=3A_Gsheet_adding_sheets_component?=
Message-ID: <162614124641.6490.7230872742445183320.asfpy@gitbox.apache.org>
Date: Tue, 13 Jul 2021 01:54:06 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
References: <superset.15598.MDExOlB1bGxSZXF1ZXN0Njg2MzUwMTgw.gitbox@gitbox.apache.org>
In-Reply-To: <superset.15598.MDExOlB1bGxSZXF1ZXN0Njg2MzUwMTgw.gitbox@gitbox.apache.org>


eschutho commented on a change in pull request #15598:
URL: https://github.com/apache/superset/pull/15598#discussion_r668369993



##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -66,23 +67,27 @@ interface FieldPropTypes {
   sslForced?: boolean;
   defaultDBName?: string;
   editNewDb?: boolean;
+  setPublicSheets: (value: string) => void;
+  isPublic?: boolean;
 }
 
 const CredentialsInfo = ({
   changeMethods,
   isEditMode,
   db,
   editNewDb,
+  isPublic,
 }: FieldPropTypes) => {
   const [uploadOption, setUploadOption] = useState<number>(
     CredentialInfoOptions.jsonUpload.valueOf(),
   );
   const [fileToUpload, setFileToUpload] = useState<string | null | undefined>(
     null,
   );
+
   return (
     <CredentialInfoForm>
-      {!isEditMode && (
+      {!isEditMode && db?.engine === 'bigquery' && (

Review comment:
       Is there any reason why we have to use ‘credentials_info’ as the key for the field? For most fields, that key is the return value for the api, but since we’re renaming it, can’t we call it something like encrypted_credentials? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org