superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [superset] pkdotson opened a new pull request #15618: refactor: icon to icons for syntaxhighlighter and querylist components
Date Fri, 09 Jul 2021 16:26:17 GMT

pkdotson opened a new pull request #15618:
URL: https://github.com/apache/superset/pull/15618


   ### SUMMARY
   This pr migrates the icons in the syntaxhighliger component and querylist.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="285" alt="Screen Shot 2021-07-09 at 9 18 50 AM" src="https://user-images.githubusercontent.com/17326228/125108962-95a16d00-e097-11eb-846e-facc6abfa486.png">
   
   
   ### TESTING INSTRUCTIONS
   Go to querylist and querypreview modal to test icons
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message