superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [superset] suddjian opened a new pull request #15577: feat(viz): Clear viz gallery when navigating between categories
Date Wed, 07 Jul 2021 20:39:04 GMT

suddjian opened a new pull request #15577:
URL: https://github.com/apache/superset/pull/15577


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   - The Add Chart page starts with no viz selected.
   - When changing categories in the viz gallery, the selected viz will be cleared - _Unless_
the selected viz is applicable to that category.
   - Disables the submit button on the modal if no viz is selected
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   <img width="1076" alt="Screen Shot 2021-07-07 at 1 36 55 PM" src="https://user-images.githubusercontent.com/1858430/124825405-6a4c4000-df28-11eb-8e0d-426b41a133e5.png">
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message