superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [superset] michael-s-molina commented on issue #15694: [Upcoming change]Enable Autocomplete filter in Edit Dataset setting by default
Date Thu, 15 Jul 2021 20:51:15 GMT

michael-s-molina commented on issue #15694:
URL: https://github.com/apache/superset/issues/15694#issuecomment-881004635


   > 1. I believe the checkbox exists as the query run to generate the autocomplete can
be very expensive on large tables, especially those with many partitions.
   
   > 2. A bigger concern I have is that the autocomplete only returns 10000 results and
in a seemingly arbitrary order. This means that it can be difficult to select the actual value
you want. 
   
   @etr2460 Both points are very important. One thing that we can do to mitigate these risks
is to use the new Select component. It will allow us to fetch data in a paginated manner and
also remove the limit on the number of results. We can submit a PR and test in Airbnb's environment
to check if performance is acceptable 😉.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message