superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [superset] eschutho commented on a change in pull request #15598: feat: Gsheet adding sheets component
Date Tue, 13 Jul 2021 01:54:06 GMT

eschutho commented on a change in pull request #15598:
URL: https://github.com/apache/superset/pull/15598#discussion_r668369993



##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -66,23 +67,27 @@ interface FieldPropTypes {
   sslForced?: boolean;
   defaultDBName?: string;
   editNewDb?: boolean;
+  setPublicSheets: (value: string) => void;
+  isPublic?: boolean;
 }
 
 const CredentialsInfo = ({
   changeMethods,
   isEditMode,
   db,
   editNewDb,
+  isPublic,
 }: FieldPropTypes) => {
   const [uploadOption, setUploadOption] = useState<number>(
     CredentialInfoOptions.jsonUpload.valueOf(),
   );
   const [fileToUpload, setFileToUpload] = useState<string | null | undefined>(
     null,
   );
+
   return (
     <CredentialInfoForm>
-      {!isEditMode && (
+      {!isEditMode && db?.engine === 'bigquery' && (

Review comment:
       Is there any reason why we have to use ‘credentials_info’ as the key for the field?
For most fields, that key is the return value for the api, but since we’re renaming it,
can’t we call it something like encrypted_credentials? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message