From notifications-return-106020-archive-asf-public=cust-asf.ponee.io@superset.apache.org  Thu Jun 24 08:00:15 2021
Return-Path: <notifications-return-106020-archive-asf-public=cust-asf.ponee.io@superset.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255])
	by mx-eu-01.ponee.io (Postfix) with ESMTPS id C300C180648
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 24 Jun 2021 10:00:15 +0200 (CEST)
Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153])
	by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 0DCC943F39
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 24 Jun 2021 07:59:59 +0000 (UTC)
Received: (qmail 92816 invoked by uid 500); 24 Jun 2021 07:59:43 -0000
Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@superset.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@superset.apache.org>
List-Post: <mailto:notifications@superset.apache.org>
List-Id: <notifications.superset.apache.org>
Reply-To: dev@superset.apache.org
Delivered-To: mailing list notifications@superset.apache.org
Received: (qmail 92796 invoked by uid 99); 24 Jun 2021 07:59:43 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jun 2021 07:59:43 +0000
From: =?utf-8?q?GitBox?= <git@apache.org>
To: notifications@superset.apache.org
Subject: =?utf-8?q?=5BGitHub=5D_=5Bsuperset=5D_zhaoyongjie_opened_a_new_pull_request_?=
 =?utf-8?q?=2315353=3A_fix=3A_raise_unexpected_error_when_orderby_is_empty?=
Message-ID: <superset.15353.MDExOlB1bGxSZXF1ZXN0Njc2ODgwODgx.gitbox@gitbox.apache.org>
Date: Thu, 24 Jun 2021 07:59:43 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit


zhaoyongjie opened a new pull request #15353:
URL: https://github.com/apache/superset/pull/15353


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   currently, Superset raises python unexpected error when `orderby` missing column. 
   
   This PR catch this exception by Marshmallow, I will fix this issue in superset-ui repo
   
   ### how to reproduce this issue
   1. open mixed timeseries chart
   2. populate a column to sort by
   3. click query button
   4. remove existing column from sort by control
   5. click query button
   6. raise `unhashable type` error
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   #### before
   ![image](https://user-images.githubusercontent.com/2016594/123224833-bbaa0780-d504-11eb-8437-3b3b86fe5db4.png)
   
   #### after
   ![image](https://user-images.githubusercontent.com/2016594/123224675-9fa66600-d504-11eb-914b-318a5a7b7a7f.png)
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org