superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [superset] zhaoyongjie opened a new pull request #15353: fix: raise unexpected error when orderby is empty
Date Thu, 24 Jun 2021 07:59:43 GMT

zhaoyongjie opened a new pull request #15353:
URL: https://github.com/apache/superset/pull/15353


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   currently, Superset raises python unexpected error when `orderby` missing column. 
   
   This PR catch this exception by Marshmallow, I will fix this issue in superset-ui repo
   
   ### how to reproduce this issue
   1. open mixed timeseries chart
   2. populate a column to sort by
   3. click query button
   4. remove existing column from sort by control
   5. click query button
   6. raise `unhashable type` error
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   #### before
   ![image](https://user-images.githubusercontent.com/2016594/123224833-bbaa0780-d504-11eb-8437-3b3b86fe5db4.png)
   
   #### after
   ![image](https://user-images.githubusercontent.com/2016594/123224675-9fa66600-d504-11eb-914b-318a5a7b7a7f.png)
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message