superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [superset] betodealmeida opened a new pull request #14093: feat: error messages when connecting to MSSQL
Date Tue, 13 Apr 2021 01:53:43 GMT

betodealmeida opened a new pull request #14093:
URL: https://github.com/apache/superset/pull/14093


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Add better error messages when connecting to MSSQL.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   <img width="1196" alt="Screen Shot 2021-04-12 at 6 49 48 PM" src="https://user-images.githubusercontent.com/1534870/114484932-e94b0a00-9bbf-11eb-8dd3-9952c9585624.png">
   <img width="1196" alt="Screen Shot 2021-04-12 at 6 49 40 PM" src="https://user-images.githubusercontent.com/1534870/114484941-ecde9100-9bbf-11eb-8cc3-3f95a8e4e623.png">
   <img width="1196" alt="Screen Shot 2021-04-12 at 6 49 05 PM" src="https://user-images.githubusercontent.com/1534870/114484945-ee0fbe00-9bbf-11eb-8a6e-b3315062e0ad.png">
   <img width="1196" alt="Screen Shot 2021-04-12 at 6 40 59 PM" src="https://user-images.githubusercontent.com/1534870/114484950-efd98180-9bbf-11eb-9f88-efd19e3661f5.png">
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   Added unit tests and tested locally (see screenshots).
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message