superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [superset] lyndsiWilliams opened a new pull request #14091: feat: FE: Import for Queries II
Date Mon, 12 Apr 2021 22:27:19 GMT

lyndsiWilliams opened a new pull request #14091:
URL: https://github.com/apache/superset/pull/14091


   ### SUMMARY
   Addeed an import button for saved queries in the subMenu.
   
   - Imported object is matched against existing objects based on uuid
   - If there are conflicts in the file being imported, user is informed and can choose to
overwrite or cancel the import
   - Any other underlying sources that don’t yet exist should be created.
   - User should be prompted for db credentials if needed
   - Any underlying sources that exist and conflict shouldn’t be overwritten
   - User sees a confirmation toast
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   #### BEFORE:
   <img width="946" alt="import-before" src="https://user-images.githubusercontent.com/55605634/114209182-f51aa000-9923-11eb-9ec9-bbc495bef9c5.png">
   
   #### AFTER:
   <img width="946" alt="import-after" src="https://user-images.githubusercontent.com/55605634/114209359-26936b80-9924-11eb-98a3-3a5265acf3c4.png">
   
   ### TEST PLAN
   Testing has been implemented to ensure the existence of the new import button and modal.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: https://app.clubhouse.io/preset/story/214/fe-import-query
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message