superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [superset] etr2460 opened a new pull request #13802: feat: don't return empty time-series
Date Thu, 25 Mar 2021 23:30:33 GMT

etr2460 opened a new pull request #13802:
URL: https://github.com/apache/superset/pull/13802


   ### SUMMARY
   When debugging a performance issue today, I ran into a situation where a stacked bar chart
had about 20k series, but all of them except 1 were filled with 0s and Nones. This took ~1
minute to render in a dashboard and froze chrome.
   
   This PR removes empty time series from time series visualizations. I'm not sure what the
consequences of this might be, so would appreciate feedback from folks. If this seems reasonable,
then I'll follow up by adding some tests.
   
   ### TEST PLAN
   CI
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   
   to: @graceguo-supercat @ktmud @villebro @mistercrunch 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message