superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [superset] etr2460 commented on a change in pull request #13634: feat(reports): SLACK_API_TOKEN as callable or str
Date Mon, 15 Mar 2021 20:56:29 GMT

etr2460 commented on a change in pull request #13634:
URL: https://github.com/apache/superset/pull/13634#discussion_r594677759



##########
File path: superset/config.py
##########
@@ -912,7 +912,7 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
 # A custom prefix to use on all Alerts & Reports emails
 EMAIL_REPORTS_SUBJECT_PREFIX = "[Report] "
 
-# Slack API token for the superset reports
+# Slack API token for the superset reports, either string or callable
 SLACK_API_TOKEN = None

Review comment:
       can we add a mypy type here? Something like `Optional[Union[Callable[..., str], str]]`
I think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message