superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Date Fri, 12 Mar 2021 14:46:19 GMT

codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
   > Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc)
(11021d5) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc)
(5fca19d) will **decrease** coverage by `6.41%`.
   > The diff coverage is `57.51%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13578/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13578      +/-   ##
   ==========================================
   - Coverage   77.53%   71.12%   -6.42%     
   ==========================================
     Files         904      827      -77     
     Lines       45986    41422    -4564     
     Branches     5552     4300    -1252     
   ==========================================
   - Hits        35657    29461    -6196     
   - Misses      10195    11961    +1766     
   + Partials      134        0     -134     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.74% <23.56%> (-0.47%)` | :arrow_down: |
   | hive | `80.06% <76.95%> (-0.07%)` | :arrow_down: |
   | javascript | `?` | |
   | mysql | `80.38% <75.46%> (-0.07%)` | :arrow_down: |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `80.77% <77.32%> (-0.23%)` | :arrow_down: |
   | sqlite | `80.05% <75.09%> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==)
| `0.00% <0.00%> (-38.89%)` | :arrow_down: |
   | [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=)
| `93.33% <ø> (-0.79%)` | :arrow_down: |
   | [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==)
| `100.00% <ø> (ø)` | |
   | [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz)
| `100.00% <ø> (ø)` | |
   | [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=)
| `100.00% <ø> (ø)` | |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==)
| `90.78% <ø> (ø)` | |
   | [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5)
| `100.00% <ø> (ø)` | |
   | [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=)
| `4.42% <4.42%> (ø)` | |
   | [...ntend/src/explore/controlUtils/getControlConfig.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2dldENvbnRyb2xDb25maWcudHM=)
| `9.52% <14.28%> (-86.48%)` | :arrow_down: |
   | [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5)
| `33.66% <20.00%> (-0.09%)` | :arrow_down: |
   | ... and [523 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer).
Last update [5fca19d...c136488](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message