superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [superset] ktmud commented on pull request #12806: refactor: speed up conversion from dataframe to list of records
Date Fri, 05 Feb 2021 19:22:34 GMT

ktmud commented on pull request #12806:
URL: https://github.com/apache/superset/pull/12806#issuecomment-774237939


   > Either way, it'd be easy enough to add this check into our function here too - via
warnings.warn() or through the logger. What would be preferred?
   
   Let's use `warnings.warn()` just to be consistent with current behavior.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message