From notifications-return-53094-archive-asf-public=cust-asf.ponee.io@superset.apache.org Tue Sep 29 03:59:48 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 54142180642 for ; Tue, 29 Sep 2020 05:59:48 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 8A00942493 for ; Tue, 29 Sep 2020 03:59:47 +0000 (UTC) Received: (qmail 2277 invoked by uid 500); 29 Sep 2020 03:59:47 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 2256 invoked by uid 99); 29 Sep 2020 03:59:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Sep 2020 03:59:46 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_mistercrunch_commented_on_a_?= =?utf-8?q?change_in_pull_request_=2311098=3A_Add_UUID_column_to_ImportMixin?= Message-ID: <160135198670.32230.11165202354304216459.asfpy@gitbox.apache.org> Date: Tue, 29 Sep 2020 03:59:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: mistercrunch commented on a change in pull request #11098: URL: https://github.com/apache/incubator-superset/pull/11098#discussion_r496363957 ########## File path: superset/models/helpers.py ########## @@ -51,6 +53,10 @@ def json_to_dict(json_str: str) -> Dict[Any, Any]: class ImportMixin: + uuid = sa.Column( Review comment: Probably out of scope of this PR, but I think we should rename `ImportMixin` to `ExportImportMixin` eventually ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org