From notifications-return-52954-archive-asf-public=cust-asf.ponee.io@superset.apache.org Sun Sep 27 18:17:24 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 81B9E18065C for ; Sun, 27 Sep 2020 20:17:24 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 0281762A56 for ; Sun, 27 Sep 2020 18:17:23 +0000 (UTC) Received: (qmail 41117 invoked by uid 500); 27 Sep 2020 18:17:23 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 41108 invoked by uid 99); 27 Sep 2020 18:17:23 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Sep 2020 18:17:23 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_codecov-commenter_edited_a_c?= =?utf-8?q?omment_on_pull_request_=2310594=3A_feat=3A_Dashboard_Level_Access?= =?utf-8?q?_=3A_dashboard_lists?= Message-ID: <160123064321.32230.4411799875542652946.asfpy@gitbox.apache.org> Date: Sun, 27 Sep 2020 18:17:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: codecov-commenter edited a comment on pull request #10594: URL: https://github.com/apache/incubator-superset/pull/10594#issuecomment-673445076 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=h1) Report > Merging [#10594](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7f1e4e441da8eff86ce31510a12a9f79e4317c9a?el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `77.77%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10594/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #10594 +/- ## ========================================== + Coverage 61.64% 61.69% +0.04% ========================================== Files 815 816 +1 Lines 38498 38646 +148 Branches 3620 3620 ========================================== + Hits 23733 23843 +110 - Misses 14579 14617 +38 Partials 186 186 ``` | Flag | Coverage Δ | | |---|---|---| | #javascript | `62.05% <ø> (ø)` | | | #python | `61.48% <77.77%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <ø> (ø)` | | | [superset/dashbaord\_level\_access\_initializer.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJhb3JkX2xldmVsX2FjY2Vzc19pbml0aWFsaXplci5weQ==) | `0.00% <0.00%> (ø)` | | | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `39.67% <20.00%> (-0.33%)` | :arrow_down: | | [superset/dashboards/security.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zZWN1cml0eS5weQ==) | `98.21% <98.21%> (ø)` | | | [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | | | [superset/dashboards/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9idWxrX2RlbGV0ZS5weQ==) | `91.66% <100.00%> (+0.75%)` | :arrow_up: | | [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | `92.85% <100.00%> (+0.54%)` | :arrow_up: | | [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.66% <100.00%> (+0.75%)` | :arrow_up: | | [superset/dashboards/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy91cGRhdGUucHk=) | `89.28% <100.00%> (+0.60%)` | :arrow_up: | | [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `97.91% <100.00%> (+1.36%)` | :arrow_up: | | ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=footer). Last update [7f1e4e4...e09a206](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org