From notifications-return-52359-archive-asf-public=cust-asf.ponee.io@superset.apache.org Wed Sep 23 05:29:05 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id A5786180660 for ; Wed, 23 Sep 2020 07:29:05 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id E32E34181F for ; Wed, 23 Sep 2020 05:29:04 +0000 (UTC) Received: (qmail 64863 invoked by uid 500); 23 Sep 2020 05:29:04 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 64853 invoked by uid 99); 23 Sep 2020 05:29:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Sep 2020 05:29:04 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_ktmud_commented_on_a_change_?= =?utf-8?q?in_pull_request_=2310455=3A_chore=3A_Migrate_Timer_component_from?= =?utf-8?q?_jsx_to_tsx?= Message-ID: <160083894452.32230.4108382547719970943.asfpy@gitbox.apache.org> Date: Wed, 23 Sep 2020 05:29:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: ktmud commented on a change in pull request #10455: URL: https://github.com/apache/incubator-superset/pull/10455#discussion_r493026991 ########## File path: superset-frontend/src/components/Timer.tsx ########## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React, { useEffect, useState } from 'react'; +import { Label } from 'react-bootstrap'; + +import { now, fDuration } from '../modules/dates'; Review comment: Please use absolute import `import .. from 'src/modules/dates'` in the future, it's easier to read (especially when multiple folders have files of the same name) and makes moving files around easier. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org