From notifications-return-53172-apmail-superset-notifications-archive=superset.apache.org@superset.apache.org Tue Sep 29 17:52:19 2020 Return-Path: X-Original-To: apmail-superset-notifications-archive@locus.apache.org Delivered-To: apmail-superset-notifications-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id C0DAF198CF for ; Tue, 29 Sep 2020 17:52:19 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 6CA49121F40 for ; Tue, 29 Sep 2020 17:52:19 +0000 (UTC) Received: (qmail 93890 invoked by uid 500); 29 Sep 2020 17:52:19 -0000 Delivered-To: apmail-superset-notifications-archive@superset.apache.org Received: (qmail 93872 invoked by uid 500); 29 Sep 2020 17:52:19 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 93863 invoked by uid 99); 29 Sep 2020 17:52:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Sep 2020 17:52:19 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_etr2460_commented_on_pull_re?= =?utf-8?q?quest_=2311099=3A_feat=3A_more_specific_presto_error_messages?= Message-ID: <160140193902.32230.8187444937587296054.asfpy@gitbox.apache.org> Date: Tue, 29 Sep 2020 17:52:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: etr2460 commented on pull request #11099: URL: https://github.com/apache/incubator-superset/pull/11099#issuecomment-700878654 I think the end goal is probably to attribute the error to the correct source (e.g. Presto, Hive, Superset, etc.), but to use Superset's layer to clarify a raw error message. So I think aligning the wording with superset is probably the right thing to do here, I'll try to make things a bit more generic throughout (while still showing to the user what the root cause service was) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org