From notifications-return-51321-apmail-superset-notifications-archive=superset.apache.org@superset.apache.org Wed Sep 16 10:53:40 2020 Return-Path: X-Original-To: apmail-superset-notifications-archive@locus.apache.org Delivered-To: apmail-superset-notifications-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id BCA1F19E92 for ; Wed, 16 Sep 2020 10:53:40 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 6B15D121B15 for ; Wed, 16 Sep 2020 10:53:40 +0000 (UTC) Received: (qmail 82786 invoked by uid 500); 16 Sep 2020 10:53:40 -0000 Delivered-To: apmail-superset-notifications-archive@superset.apache.org Received: (qmail 82768 invoked by uid 500); 16 Sep 2020 10:53:40 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 82759 invoked by uid 99); 16 Sep 2020 10:53:40 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Sep 2020 10:53:40 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_akelai_edited_a_comment_on_i?= =?utf-8?q?ssue_=2310708=3A_URLs_that_are_generated_e=2Eg=2E_on_tabs=2C_to_b?= =?utf-8?q?e_copy-pasted_elsewhere=2C_have_=22127=2E0=2E0=2E1=3A8088=22_inst?= =?utf-8?q?ead_of_the_actual_address_to_reach_the_Superset_application?= Message-ID: <160025362010.32230.3277305394145894463.asfpy@gitbox.apache.org> Date: Wed, 16 Sep 2020 10:53:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: akelai edited a comment on issue #10708: URL: https://github.com/apache/incubator-superset/issues/10708#issuecomment-693295999 Update: I noticed that the "Share Query" button in SQL Lab doesn't have this problem, i.e. it works fine, generating the share URL with the actual domain. Is it possible to have the same (working) behavior for all the share URLs that can be generated in Superset? Maybe it has something to do with the fact that for the "Share Query" button in SQL Lab there is code like this: ``` savedQueryToastContent = `${window.location.origin + window.location.pathname}?savedQueryId=${this.props.queryEditor.remoteId}`; ``` ...while in other places there is code like this: ``` url: window.location.href.substring(window.location.origin.length) ``` ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org