superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] eschutho opened a new pull request #11121: remove extra flash import
Date Wed, 30 Sep 2020 19:45:10 GMT

eschutho opened a new pull request #11121:
URL: https://github.com/apache/incubator-superset/pull/11121


   ### SUMMARY
   @mistercrunch found this bug: 
   ![image](https://user-images.githubusercontent.com/5186919/94732000-7f9d9980-031a-11eb-9347-e8a2bd620301.png)
   
   This removes the extra error message, and also adds an `accept` on the file input to only
allow the user to select the formats that are valid. I'm still confirming whether or not .json
should be a valid option. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   no visual tests available, but all other regression tests should pass
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message